SDK support for server #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- remove fields that are not in the backend API endpoint. - modify the upload archive url
- add server address - return sessionId for testing
- earlier class.weave.dat file was uploaded from sdk to server. Now, that file is no longer needed. - Also, base time was getting set from session-weave-dat zip filename. Now, that also happens from log.txt file that would eventually come from index-*.zip files. - Since, the zip file is no longer needed, it's creation and build flow is removed.
|
Test Plan:
|
artpar
requested changes
May 15, 2024
src/main/java/io/unlogged/logging/perthread/RawFileCollector.java
Outdated
Show resolved
Hide resolved
artpar
reviewed
May 15, 2024
artpar
reviewed
May 15, 2024
artpar
reviewed
May 22, 2024
| @@ -95,6 +90,20 @@ private Runtime(String args) { | |||
|
|
|||
| errorLogger = new SimpleFileLogger(outputDir); | |||
|
|
|||
| String hostname = null; | |||
There was a problem hiding this comment.
use NetworkClient.getHostname()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
serverLink: is the base url of server