feat(preset-mini): customizing dark mode selector #1250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for unocss ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
antfu
reviewed
Jul 13, 2022
packages/preset-mini/src/index.ts
Outdated
| export interface PresetMiniOptions extends PresetOptions { | ||
| /** | ||
| * @default 'class' | ||
| */ | ||
| dark?: 'class' | 'media' | ||
| dark?: 'class' | 'media' | ['class', DarkSelector] |
There was a problem hiding this comment.
Suggested change
| dark?: 'class' | 'media' | ['class', DarkSelector] | |
| dark?: 'class' | 'media' | DarkModeSelectors |
antfu
reviewed
Jul 13, 2022
packages/preset-mini/src/index.ts
Outdated
| @@ -11,7 +11,7 @@ export { parseColor } from './utils' | |||
|
|
|||
| export type { ThemeAnimation, Theme } | |||
|
|
|||
| interface DarkSelector { | |||
| type DarkModeSelectors = ['class', { | |||
There was a problem hiding this comment.
I think a simple object is enough, the array feels redundant to me (plus they are not always class anyway)
There was a problem hiding this comment.
Same as I thought, not sure why tailwindicss needs to set a class
MellowCo
added a commit
to MellowCo/unocss-preset-weapp
that referenced
this pull request
Jul 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close: #1248