Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(preset-mini): customizing dark mode selector #1250

Merged
merged 7 commits into from Jul 13, 2022
Merged

feat(preset-mini): customizing dark mode selector #1250

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
42b4256
feat(preset-mini): customizing dark mode selector
Dunqing Jul 13, 2022
6f1a9f6
test: add test
Dunqing Jul 13, 2022
3b2e98a
test: update test
Dunqing Jul 13, 2022
e7f6a94
feat: update types
Dunqing Jul 13, 2022
168f2ad
feat: improve type
Dunqing Jul 13, 2022
3cfc65d
test: fix
Dunqing Jul 13, 2022
dda2f85
chore: update
antfu Jul 13, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 3 additions & 3 deletions packages/preset-mini/src/index.ts
View file
Open in desktop
Expand Up @@ -11,7 +11,7 @@ export { parseColor } from './utils'

export type { ThemeAnimation, Theme }

interface DarkSelector {
type DarkModeSelectors = ['class', {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think a simple object is enough, the array feels redundant to me (plus they are not always class anyway)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as I thought, not sure why tailwindicss needs to set a class

/**
* @default '.light'
*/
Expand All @@ -21,13 +21,13 @@ interface DarkSelector {
* @default '.dark'
*/
dark?: string
}
}]

export interface PresetMiniOptions extends PresetOptions {
/**
* @default 'class'
*/
dark?: 'class' | 'media' | ['class', DarkSelector]
dark?: 'class' | 'media' | DarkModeSelectors
/**
* @default false
*/
Expand Down