Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vite): don't escape css in vue web components #1945

Merged
merged 3 commits into from Dec 2, 2022
Merged

Conversation

sibbng
Copy link
Member

@sibbng sibbng commented Dec 2, 2022

Fixes #1943

@sibbng sibbng requested a review from antfu as a code owner December 2, 2022 00:10
@netlify
Copy link

netlify bot commented Dec 2, 2022

Deploy Preview for unocss ready!

Name Link
🔨 Latest commit 0bcdd01
🔍 Latest deploy log https://app.netlify.com/sites/unocss/deploys/63896b072c74c60009d6d899
😎 Deploy Preview https://deploy-preview-1945--unocss.netlify.app/play
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@@ -98,20 +100,23 @@ export function ShadowDomModuleModePlugin({ uno }: UnocssPluginContext): Plugin
}
}

if (id.includes('?vue&type=style') || (id.endsWith('.vue') && vueSFCStyleRE.test(code)))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a comment, explaining the reason a bit?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done 👍

@antfu antfu merged commit d4c6419 into main Dec 2, 2022
@antfu antfu deleted the fix/vue-web-components branch December 2, 2022 03:16
praburangki pushed a commit to praburangki/unocss that referenced this pull request Jan 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

in 'shadow-dom' mode, class "bg-#d00" will be converted to “.bg-\\#dd0000 {...}”
2 participants