feat(vite, webpack): add extraContent option
#1963
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for unocss ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
This was referenced Dec 16, 2022
antfu
changed the title
watchExternal optionextraContent option
antfu
changed the title
extraContent optionextraContent option
|
I renamed the options to be It seems to work, /cc @sibbng if you can help verify I didn't accidentally break anything. |
praburangki
pushed a commit
to praburangki/unocss
that referenced
this pull request
Jan 12, 2023
* feat(vite): add `watchExternal` option * chore: lint * refactor: api Co-authored-by: Anthony Fu <anthonyfu117@hotmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1944
Fixes #1937 // astro islands
Fixes #1734 // astro islands
Fixes #1947 // nuxt content
Fixes #2005 // nuxt content
I wanted to emphasize the external word by naming it
watchExternal. Otherwise calling it something more generic might confuse people who migrate from other tools.We're applying transformer plugins to files captured by this filter. But not really transforming them. Since those files are not processed by Vite, it's better to not transform them at all. I far as I see, our CLI package directly modify source files which is something really unintuitive.
In the case of Astro, files captured by this filter will go through transformer plugins. Because client-only components in Astro will be processed by Vite during client build. Since we already applied transformers on the SSR side manually, the required classes are already generated in bundled CSS.