Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: vite build --watch not emitting anything #2108

Merged
merged 1 commit into from Jan 25, 2023

Conversation

clarkf
Copy link
Contributor

@clarkf clarkf commented Jan 25, 2023

There was a regression introduced in b7a6687 where vite projects built using vite build --watch will only generate once. Subsequent generations will just leave the placeholder.

My solution here was to add the layers as they're loaded, rather than removing the clear.

Re-fixes #963
See #1963 - it's unclear why this reintroduced the issue, I'm not familiar enough with nuxt or astro.

There was a regression introduced by b7a6687
where vite projects built using `vite build --watch` will only generate once.
Subsequent generations will just leave the placeholder.

See unocss#963
@clarkf clarkf requested a review from antfu as a code owner January 25, 2023 01:35
@netlify
Copy link

netlify bot commented Jan 25, 2023

Deploy Preview for unocss ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit a1ec045
🔍 Latest deploy log https://app.netlify.com/sites/unocss/deploys/63d08761b92d120008c4d686
😎 Deploy Preview https://deploy-preview-2108--unocss.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@antfu antfu merged commit 3b414da into unocss:main Jan 25, 2023
@clarkf clarkf deleted the fix-vite-watch branch January 25, 2023 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants