Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vscode): reload command #2979

Merged
merged 1 commit into from Aug 13, 2023
Merged

fix(vscode): reload command #2979

merged 1 commit into from Aug 13, 2023

Conversation

Jannchie
Copy link
Contributor

@Jannchie Jannchie commented Aug 13, 2023

I want to be able to load the unocss extension without restarting the whole vscode when installing unocss in a project.

Currently, the unocss.reload command is not registered when unocss is not installed in the workspace.

This is caused by throwing the ➖ No config found in ${cwd} exception. I rewrote this part of the code to not let the exception be thrown and not affect the original logic.

Additionally, I put registerRoot in the callback of the reload command so that it can check if unocss is installed.

@Jannchie Jannchie requested a review from antfu as a code owner August 13, 2023 12:24
@netlify
Copy link

netlify bot commented Aug 13, 2023

Deploy Preview for unocss ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit e55ee61
🔍 Latest deploy log https://app.netlify.com/sites/unocss/deploys/64d8cba6dced190009cbd8f2
😎 Deploy Preview https://deploy-preview-2979--unocss.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@antfu antfu added this pull request to the merge queue Aug 13, 2023
Merged via the queue into unocss:main with commit 2c92b9c Aug 13, 2023
10 checks passed
@Jannchie Jannchie deleted the fix/reload branch August 13, 2023 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants