Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vscode): registerRoot calling #2992

Closed
wants to merge 2 commits into from

Conversation

Thehrz
Copy link

@Thehrz Thehrz commented Aug 16, 2023

In #2979, registerRoot was placed in the callback of the reload command, which required us to run the reload command in v0.55.1 in order to load the context. This may lead some users to think that the unocss vscode extension is not working.
This PR rolled back the behavior before v0.55.1.

@Thehrz Thehrz requested a review from antfu as a code owner August 16, 2023 15:49
@netlify
Copy link

netlify bot commented Aug 16, 2023

Deploy Preview for unocss ready!

Name Link
🔨 Latest commit 6a4877b
🔍 Latest deploy log https://app.netlify.com/sites/unocss/deploys/64e0dc79dfde01000830d130
😎 Deploy Preview https://deploy-preview-2992--unocss.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@KraXen72
Copy link

please also check, if this fixes files with /* @unocss-include */ not loading. as you said, i have to run reload unocss command, to load the extension, but i also have to manually remove and add this for unocss to register the files. would be great if it was fixed in one pr!

@Thehrz
Copy link
Author

Thehrz commented Aug 18, 2023

please also check, if this fixes files with /* @unocss-include */ not loading. as you said, i have to run reload unocss command, to load the extension, but i also have to manually remove and add this for unocss to register the files. would be great if it was fixed in one pr!

Hi, I checked the @unocss-include magic comment and it seems to work, can you please describe more? Or you can open a new issue.

@KraXen72
Copy link

sorry, i tested it and it works now. i was using the svelte-scoped preset which does not have config hmr, so it wasn't working. but with normal unocss/vite, it works. thanks.

@zyyv zyyv added the vscode label Aug 19, 2023
@Thehrz
Copy link
Author

Thehrz commented Aug 20, 2023

fixed in #3005, close it.

@Thehrz Thehrz closed this Aug 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants