Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add missing types exports field #1568

Merged
merged 2 commits into from Sep 9, 2022
Merged

chore: add missing types exports field #1568

merged 2 commits into from Sep 9, 2022

Conversation

kidonng
Copy link
Contributor

@kidonng kidonng commented Sep 7, 2022

Some plugins are missing types field in package.json's exports, which is required for TypeScript to work under "module": "node16".

Note: I removed types added in #1484 because they are never actually referenced (or used).

@netlify
Copy link

netlify bot commented Sep 7, 2022

Deploy Preview for unocss ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 2787d99
🔍 Latest deploy log https://app.netlify.com/sites/unocss/deploys/631ae567347986000958f911
😎 Deploy Preview https://deploy-preview-1568--unocss.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@ydcjeff
Copy link
Member

ydcjeff commented Sep 9, 2022

Can you revert the types that you have removed? They are required to work under moduleResolution: "node".

@kidonng
Copy link
Contributor Author

kidonng commented Sep 9, 2022

I was confused by the way TypeScript deal with exports LOL. (To begin with, I'm unfamiliar with packages with multiple entry points).

unocss types are restored as requested.

@ydcjeff ydcjeff merged commit 2075df9 into unocss:main Sep 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants