Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(preset-mini)!: update @media variant #1698

Closed
wants to merge 1 commit into from

Conversation

chu121su12
Copy link
Collaborator

With getComponent helper, media-x variant can more safely accept bracket value.

This PR remove the auto variable for the media-x value, instead opting for bracket to achieve similar functionality. Bracket value is now supported and theme lookup is unchanged.

This also aligns media-x syntax with support-x syntax

@chu121su12 chu121su12 changed the title feat(preset-mini,preset-wind)!: update @media variant feat(preset-mini)!: update @media variant Oct 8, 2022
@netlify
Copy link

netlify bot commented Oct 8, 2022

Deploy Preview for unocss ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 8e6480c
🔍 Latest deploy log https://app.netlify.com/sites/unocss/deploys/634113a288f82b0008215f20
😎 Deploy Preview https://deploy-preview-1698--unocss.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@chu121su12 chu121su12 marked this pull request as ready for review October 8, 2022 06:13
@chu121su12 chu121su12 requested a review from antfu as a code owner October 8, 2022 06:13
@chu121su12 chu121su12 marked this pull request as draft October 8, 2022 14:04
@chu121su12
Copy link
Collaborator Author

Closed in favor of #1704

@chu121su12 chu121su12 closed this Oct 9, 2022
@chu121su12 chu121su12 deleted the feat/at-media branch October 10, 2022 04:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants