Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

revert(vite): applyCssTransform on bundle generation (#1900) #1902

Closed
wants to merge 1 commit into from
Closed

revert(vite): applyCssTransform on bundle generation (#1900) #1902

wants to merge 1 commit into from

Conversation

MellowCo
Copy link
Contributor

@MellowCo MellowCo commented Nov 22, 2022 •
edited

Linked issue: #1900

@MellowCo MellowCo requested a review from antfu as a code owner November 22, 2022 14:51
@netlify
Copy link

netlify bot commented Nov 22, 2022 •
edited

✅ Deploy Preview for unocss ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit cb976cb
🔍 Latest deploy log https://app.netlify.com/sites/unocss/deploys/637ce1e72aebe50009a723e1
😎 Deploy Preview https://deploy-preview-1902--unocss.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@antfu
Copy link
Member

antfu commented Nov 22, 2022 •
edited

Thanks. Can you help check if #1850 can be fixed with this approach?

@MellowCo
Copy link
Contributor Author

MellowCo commented Nov 23, 2022 •
edited

It looks like vite has transform the public folder

image

https://github.com/vitejs/vite/blob/892916d040a035edde1add93c192e0b0c5c9dd86/packages/vite/src/node/plugins/css.ts#L204-L210

https://github.com/vitejs/vite/blob/892916d040a035edde1add93c192e0b0c5c9dd86/packages/vite/src/node/plugins/asset.ts#L262-L281

@sibbng sibbng mentioned this pull request Nov 29, 2022
Merged
@antfu antfu closed this in #1926 Nov 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antfu antfu Awaiting requested review from antfu antfu is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@MellowCo @antfu