refactor(preset-attributify): improve element extractor #2187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for unocss ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
chu121su12
approved these changes
Feb 13, 2023
There was a problem hiding this comment.
LGTM. Using the example in https://regex101.com/r/48y4HT/1 the new matcher improves the loop from 403 to 13 steps.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1584
Fixes #2112
Supersedes #2134
@chu121su12 I tried pasting your code on playground and it was slowing down the editor. Every key store was taking 3-4 seconds on my machine. With this PR it seems instant as it should be.
I also tested this PR with the provided repro in #2067, and it successfully builds.