Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(preset-mini): split focus pseudo #2426

Merged
merged 4 commits into from Apr 9, 2023
Merged

Conversation

chu121su12
Copy link
Collaborator

See #2416, #2425.

@sibbng I read your comment late, but I think #1973 should be addressed too.

I manage to isolate the mentioned issue to focus pseudo, but this is a temporary fix, since it still handle compound pseudo, say focus:active:x, wrong.

@netlify
Copy link

netlify bot commented Apr 2, 2023

Deploy Preview for unocss ready!

Name Link
🔨 Latest commit 9c7f822
🔍 Latest deploy log https://app.netlify.com/sites/unocss/deploys/64326d03a7e017000847c48c
😎 Deploy Preview https://deploy-preview-2426--unocss.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@sibbng
Copy link
Member

sibbng commented Apr 4, 2023

We should disable merging behavior for pseudos and remove that sort option for both active and focus. We already have order control in the array we define those pseudos. Since those pseudos represent a certain state, merging them with a rule up in the tree is a bad idea. I think, in general, merging rules across the whole css is a bad idea. There are some reasons to pursue that, but I already found better solutions for those reasons in #1973. I will look into it again ASAP.

I was thinking of breaking #1973 into multiple parts. If we can fix the issues you mentioned by disabling merging behavior on pseudos that would be a good start.

@chu121su12 chu121su12 marked this pull request as ready for review April 4, 2023 11:44
@chu121su12 chu121su12 requested a review from antfu as a code owner April 4, 2023 11:44
@antfu antfu merged commit 835fff5 into unocss:main Apr 9, 2023
9 checks passed
@chu121su12 chu121su12 deleted the fix-pseudo branch October 24, 2023 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants