Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: describe preset options #2434

Merged
merged 10 commits into from Apr 4, 2023
Merged

docs: describe preset options #2434

merged 10 commits into from Apr 4, 2023

Conversation

zyyv
Copy link
Member

@zyyv zyyv commented Apr 4, 2023

No description provided.

@zyyv zyyv requested a review from antfu as a code owner April 4, 2023 02:35
@zyyv zyyv marked this pull request as draft April 4, 2023 02:35
@netlify
Copy link

netlify bot commented Apr 4, 2023

Deploy Preview for unocss ready!

Name Link
🔨 Latest commit 5d9f4d3
🔍 Latest deploy log https://app.netlify.com/sites/unocss/deploys/642c24396eac2b0008ff716d
😎 Deploy Preview https://deploy-preview-2434--unocss.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@zyyv zyyv changed the title docs: add preset configurations docs: describe preset options Apr 4, 2023
@zyyv zyyv marked this pull request as ready for review April 4, 2023 03:16
Copy link
Member

@antfu antfu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess you need to enable corepack or upgrade your pnpm. The lock is diffing

@zyyv zyyv requested a review from userquin as a code owner April 4, 2023 08:20
@zyyv
Copy link
Member Author

zyyv commented Apr 4, 2023

I guess you need to enable corepack or upgrade your pnpm. The lock is diffing

In fact, that is the lock file after I upgraded.😅
Now, I have downgraded the pnpm version same as packageManager.

@zyyv zyyv requested a review from antfu April 4, 2023 08:31

Custom icon unit.

### cdn
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I need to review current state for runtime, maybe we need to add some more hints here

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the PR LGTM, can be added later if necessary

Copy link
Member

@userquin userquin Apr 4, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#1555 : last comment from Anthony

@antfu antfu merged commit 0146030 into unocss:main Apr 4, 2023
4 of 9 checks passed
@zyyv zyyv deleted the docs-options branch April 4, 2023 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants