Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(transformer-variant-group): breakpoint alias #2583

Merged
merged 1 commit into from
May 9, 2023

Conversation

enkot
Copy link
Contributor

@enkot enkot commented May 7, 2023

Fixes #2582

Not sure if there are caveats to this solution, but it solves the problem.

@enkot enkot requested a review from antfu as a code owner May 7, 2023 09:50
@netlify
Copy link

netlify bot commented May 7, 2023

Deploy Preview for unocss ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 8f7da86
🔍 Latest deploy log https://app.netlify.com/sites/unocss/deploys/64577452a114f4000891c5b8
😎 Deploy Preview https://deploy-preview-2583--unocss.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@zyyv
Copy link
Member

zyyv commented May 8, 2023

In order to distinguish the variants of windi and retain the style of UnoCSS, we use the lt- variant as a replacement.
There are many more, such as using _ to distinguish from windicss - ...

@enkot
Copy link
Contributor Author

enkot commented May 8, 2023

@zyyv @antfu But aliases are supported in Unocss - #2266, isn't it?

@zyyv
Copy link
Member

zyyv commented May 8, 2023

Sorry, I overlooked the change #2266.
A long time ago, someone sent a similar PR change, and it was closed in order to maintain a unique style.

I will set it back to open, keep it active.

@zyyv zyyv reopened this May 8, 2023
@enkot
Copy link
Contributor Author

enkot commented May 8, 2023

@zyyv Thanks!

@antfu antfu merged commit 85ca097 into unocss:main May 9, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

transformer-variant-group doesn't work with <, ~ breakpoint aliases
3 participants