fix(preset-mini): remove num === 0 in px handler to fix offset utility issues #3271
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes a
num === 0
check in the px handler which returned0
which broke a bunch of offset-utilities (ring-offset-0
,underline-offset-0
). This means it returns0px
now and these utilities work again.The
num === 0
check is still there for the rem handler soinset-0
still gives a0
result. (I'm not sure why this is better than 0px though)It's possible there's a better way to fix this, in that case feel free to close this PR.
fixes #3196