fix(nuxt): temporary revert #3448 #3482
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit da0e476.
✅ Deploy Preview for unocss ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
antfu
reviewed
Jan 1, 2024
| * | ||
| * @default 'first' | ||
| */ | ||
| injectPosition?: 'first' | 'last' | number | { after?: string } |
There was a problem hiding this comment.
Removing this will be a breaking change, we should keep the type and do a console warning to say "We temporarily reverted the support for injectPosition while seeking for better solution. It's not effective at this moment."
antfu
changed the title
antfu
approved these changes
Jan 2, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #3448
Sorry, cause my lack of some tests, this error appeared.
I will consider another way to implement
injectposition.Related #3472 #3468