Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(directives): avoid requiring quotes in --at-apply causes misun… #3578

Conversation

zhangzheheng12345
Copy link
Contributor

In issue #3574 a user has used @apply 'hover:bg-red' (for exmaple) in which the quotes are actually not required. ONLY --at-appy needs them. The doc should be fixed to avoid this misunderstanding.

Copy link

netlify bot commented Feb 25, 2024

Deploy Preview for unocss ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 6371282
🔍 Latest deploy log https://app.netlify.com/sites/unocss/deploys/65e2e7900e35600008886e89
😎 Deploy Preview https://deploy-preview-3578--unocss.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@zhangzheheng12345
Copy link
Contributor Author

This change should be reconsidered.

Further feedback from issue #3574 shows that formatter of the editor will automically format @apply hover:bg-red to @apply hover: bg-red (tested on VS Code, builtin formatter). So I think we should SUPPORT quotes when using @apply.

@antfu antfu added this pull request to the merge queue Mar 3, 2024
Merged via the queue into unocss:main with commit 48cc394 Mar 3, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants