New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(variant-group): hmr in vite #3741
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for unocss ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
I am not sure about it - can you explain a bit more about the problem and why this would be helpful? |
|
Morning, @antfu |
I feel that there is no need to add |
@@ -40,7 +40,7 @@ export async function applyTransformers( | |||
} | |||
|
|||
if (code !== original) { | |||
ctx.affectedModules.add(id) | |||
// ctx.affectedModules.add(id) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems that this line of code is not needed. It will cause additional updates. For example, I modified file a, but multiple files may be added to the change list for the first time. Modification of file a will cause hot updates of all files. uno.css is also updated multiple times. If the a file changes, you should only need to initiate the hot update of the a file and the hot update of uno.css.
close: #3518