Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for path with brackets () #419

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Amber-372
Copy link

@Amber-372 Amber-372 commented Aug 14, 2023

Add support for path with brackets ()

Description

Linked Issues

#416

Additional context

Add support for path width brackets ()
@Amber-372 Amber-372 changed the title Update ctx.ts feat: add support for path width brackets () Aug 14, 2023
@Amber-372 Amber-372 changed the title feat: add support for path width brackets () feat: add support for path with brackets () Aug 14, 2023
@Amber-372
Copy link
Author

Amber-372 commented Aug 21, 2023

@antfu Please help to merge , thank you~ thank you~ thank you~

It's a upgrade about fast-glob.
https://github.com/mrmlnc/fast-glob#why-are-parentheses-match-wrong

Also, unplugin-vue-components needs upgrade too.

@antfu
Copy link
Member

antfu commented Aug 21, 2023

It would be better to implement within resolveGlobsExclude with a comment explaining what it this doing.

@Amber-372
Copy link
Author

Amber-372 commented Aug 22, 2023

It would be better to implement within resolveGlobsExclude with a comment explaining what it this doing.

@antfu Sorry, I'm not very familiar with the source code. Count you add this feature to the master version where appropriate?And this merger is inessential.
And, What I Want is a released version of NPM. I hope you will consider to release a version with this feather.
Thank you so much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants