Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: include dual cjs/esm in package exports #447

Merged
merged 3 commits into from
Nov 24, 2023
Merged

feat!: include dual cjs/esm in package exports #447

merged 3 commits into from
Nov 24, 2023

Conversation

userquin
Copy link
Member

@userquin userquin commented Nov 23, 2023 •
edited

Description

This PR include:

  • removes the postinstall script, using default output from tsup seem to be ok
  • split package exports in require/import
  • include publint

Linked Issues

Additional context

Current types:

imagen

With this PR:

imagen

@stackblitz StackBlitz
Copy link

stackblitz bot commented Nov 23, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@socket-security Socket Security
Copy link

New dependencies detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives Size Publisher
publint 0.2.5 None +1 96.7 kB bluwy

@userquin userquin marked this pull request as draft November 23, 2023 21:30
@userquin

This comment was marked as resolved.

Sign in to view
@userquin userquin marked this pull request as ready for review November 23, 2023 22:12
@userquin userquin requested a review from antfu November 23, 2023 22:15
@userquin userquin changed the title fix: include dual cjs/esm in package exports feat!: include dual cjs/esm in package exports Nov 23, 2023
@userquin userquin merged commit b43b317 into main Nov 24, 2023
6 checks passed
@userquin userquin deleted the userquin/fix-package-exports branch November 24, 2023 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antfu antfu Awaiting requested review from antfu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@userquin