Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: fix examples #448

Merged
merged 1 commit into from
Nov 23, 2023
Merged

chore: fix examples #448

merged 1 commit into from
Nov 23, 2023

Conversation

userquin
Copy link
Member

@userquin userquin commented Nov 23, 2023 •
edited

Description

Any example NOT working:

  • vite-svelte: added type module
  • vite-react: added type module
  • solid-js: added type module, switched to @solid/router from solid-app-router
  • included @svgr/plugin-jsx as dev dependency in root to run vite-react example

Linked Issues

Additional context

@stackblitz StackBlitz
Copy link

stackblitz bot commented Nov 23, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@userquin userquin requested a review from antfu November 23, 2023 22:25
@antfu antfu merged commit 8d65e76 into main Nov 23, 2023
6 checks passed
@antfu antfu deleted the userquin/fix-examples branch November 23, 2023 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antfu antfu Awaiting requested review from antfu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@userquin @antfu