Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: compatible with @vitejs/plugin-vue2-jsx #557

Merged
merged 4 commits into from Dec 1, 2022
Merged

feat: compatible with @vitejs/plugin-vue2-jsx #557

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1848ff1
feat: support @vitejs/plugin-vue2-jsx
windsonR Nov 23, 2022
d2107df
fix: use regex group
windsonR Nov 30, 2022
a8baef7
test: add vue2 jsx test
windsonR Nov 30, 2022
69db47f
Update src/core/transforms/component.ts
antfu Dec 1, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/core/transforms/component.ts
View file
Open in desktop
Expand Up @@ -10,15 +10,15 @@ const debug = Debug('unplugin-vue-components:transform:component')
const resolveVue2 = (code: string, s: MagicString) => {
const results: ResolveResult[] = []

for (const match of code.matchAll(/_c\([\s\n\t]*['"](.+?)["']([,)])/g)) {
for (const match of code.matchAll(/[(_c)h]\([\s\n\t]*['"](.+?)["']([,)])/g)) {
const [full, matchedName, append] = match

if (match.index != null && matchedName && !matchedName.startsWith('_')) {
const start = match.index
const end = start + full.length
results.push({
rawName: matchedName,
replace: resolved => s.overwrite(start, end, `_c(${resolved}${append}`),
replace: resolved => s.overwrite(start, end, `${full.split('(')[0]}(${resolved}${append}`),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could use group to capture it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have change it to group.
And I add a test for it.
please review it when you have time.
thanks

})
}
}
Expand Down