chore: add 'themeName' option for ElementUiResolver #662
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sxzz
approved these changes
Jul 21, 2023
sxzz
requested changes
Jul 21, 2023
|
|
||
| /** | ||
| * theme name, like '@qzdata/element-theme-qzdata' | ||
| */ |
There was a problem hiding this comment.
Add @default element-ui/packages/theme-chalk
| @@ -16,24 +16,43 @@ export interface ElementUiResolverOptions { | |||
| * exclude component name, if match do not resolve the name | |||
| */ | |||
| exclude?: RegExp | |||
|
|
|||
| /** | |||
| * theme name, like '@qzdata/element-theme-qzdata' | |||
There was a problem hiding this comment.
Suggested change
| * theme name, like '@qzdata/element-theme-qzdata' | |
| * theme name |
| } | ||
|
|
||
| function getSideEffects( | ||
| partialName: string, | ||
| options: ElementUiResolverOptions, | ||
| ): SideEffectsInfo | undefined { | ||
| const { importStyle = 'css' } = options | ||
| const { importStyle = 'css', themeName } = options |
There was a problem hiding this comment.
Suggested change
| const { importStyle = 'css', themeName } = options | |
| const { importStyle = 'css', themeName = 'element-ui/packages/theme-chalk' } = options |
Comment on lines
+36
to
+42
| if (themeName) { | ||
| return [ | ||
| `${themeName}/src/base.scss`, | ||
| `${themeName}/src/${partialName}.scss`, | ||
| ] | ||
| } | ||
|
|
There was a problem hiding this comment.
We can remove if (themeName) { check if there's a default value.
| return [ | ||
| 'element-ui/packages/theme-chalk/src/base.scss', | ||
| `element-ui/packages/theme-chalk/src/${partialName}.scss`, | ||
| ] | ||
| } | ||
| else { | ||
| if (themeName) { |
Co-authored-by: 内小子 <nbn1209@126.com>
|
Close due to inactive - feel free to bring it back if anyone interested in continue it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Linked Issues
Additional context