Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: move prettier-ignore statement so it works #729

Merged
merged 1 commit into from May 1, 2024
Merged

Conversation

HookyGV
Copy link
Contributor

@HookyGV HookyGV commented Jan 20, 2024

Description

Solve the prettier formatting issue, but leave the comment in the head section. prettier-ignore will ignore following block (the module declaration) in this case.
See https://prettier.io/docs/en/ignore.html#javascript

Linked Issues

Same issue, different solution: PR #689

Additional context

@HookyGV HookyGV requested a review from antfu as a code owner January 20, 2024 03:36
Copy link

stackblitz bot commented Jan 20, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@@ -114,20 +114,14 @@ export function getDeclaration(ctx: Context, filepath: string, originalImports?:
directive: stringifyDeclarationImports({ ...originalImports?.directive, ...imports.directive }),
}

const head = ctx.options.version === 2.7
Copy link
Contributor Author

@HookyGV HookyGV Jan 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that both paths here resolve to the same string, so this check is no longer required.

@HookyGV HookyGV changed the title fix: Move prettier-ignore statement so it works Move prettier-ignore statement so it works Jan 20, 2024
@antfu antfu changed the title Move prettier-ignore statement so it works fix: move prettier-ignore statement so it works May 1, 2024
@antfu antfu merged commit e0d37b0 into unplugin:main May 1, 2024
9 checks passed
hiifong pushed a commit to hiifong/gitno-ui that referenced this pull request May 1, 2024
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
|
[unplugin-vue-components](https://togithub.com/unplugin/unplugin-vue-components)
| [`^0.26.0` ->
`^0.27.0`](https://renovatebot.com/diffs/npm/unplugin-vue-components/0.26.0/0.27.0)
|
[![age](https://developer.mend.io/api/mc/badges/age/npm/unplugin-vue-components/0.27.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/unplugin-vue-components/0.27.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/unplugin-vue-components/0.26.0/0.27.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/unplugin-vue-components/0.26.0/0.27.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>unplugin/unplugin-vue-components
(unplugin-vue-components)</summary>

###
[`v0.27.0`](https://togithub.com/unplugin/unplugin-vue-components/releases/tag/v0.27.0)

[Compare
Source](https://togithub.com/unplugin/unplugin-vue-components/compare/v0.26.0...v0.27.0)

#####    🚀 Features

-   **ant-design-vue**:
- Support `css-in-js` import style  -  by
[@&#8203;JohnsonHuang4396](https://togithub.com/JohnsonHuang4396),
[@&#8203;antfu](https://togithub.com/antfu), **黄启浩** and
**JohnsonHuang** in
[unplugin/unplugin-vue-components#703
[<samp>(5d533)</samp>](https://togithub.com/unplugin/unplugin-vue-components/commit/5d533b1)
-   **idux**:
- Update idux resolver to support v2 version  -  by
[@&#8203;sallerli1](https://togithub.com/sallerli1), **李志超44657** and
[@&#8203;antfu](https://togithub.com/antfu) in
[unplugin/unplugin-vue-components#722
[<samp>(c1458)</samp>](https://togithub.com/unplugin/unplugin-vue-components/commit/c145885)
-   **prime-vue**:
- Update missing components  -  by
[@&#8203;evgeniikostiukov](https://togithub.com/evgeniikostiukov) in
[unplugin/unplugin-vue-components#735
[<samp>(b9140)</samp>](https://togithub.com/unplugin/unplugin-vue-components/commit/b9140de)
- Add missing components  -  by
[@&#8203;tugcekucukoglu](https://togithub.com/tugcekucukoglu) and
[@&#8203;antfu](https://togithub.com/antfu) in
[unplugin/unplugin-vue-components#731
[<samp>(858ce)</samp>](https://togithub.com/unplugin/unplugin-vue-components/commit/858ce68)
-   **varlet-ui**:
- Support `styleExtname` option  -  by
[@&#8203;RSS1102](https://togithub.com/RSS1102) in
[unplugin/unplugin-vue-components#740
[<samp>(c0e66)</samp>](https://togithub.com/unplugin/unplugin-vue-components/commit/c0e66f3)

#####    🐞 Bug Fixes

- Move `prettier-ignore` statement so it works  -  by
[@&#8203;HookyGV](https://togithub.com/HookyGV) in
[unplugin/unplugin-vue-components#729
[<samp>(e0d37)</samp>](https://togithub.com/unplugin/unplugin-vue-components/commit/e0d37b0)
- **utils**: Collapse prefixes in PascalCase name  -  by
[@&#8203;waynzh](https://togithub.com/waynzh) in
[unplugin/unplugin-vue-components#744
[<samp>(02712)</samp>](https://togithub.com/unplugin/unplugin-vue-components/commit/027128c)

#####     [View changes on
GitHub](https://togithub.com/unplugin/unplugin-vue-components/compare/v0.26.0...v0.27.0)

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/hiifong/gitno-ui).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zMzEuMCIsInVwZGF0ZWRJblZlciI6IjM3LjMzMS4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants