Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User's exclude config maybe cause Vite's pre-bundled file's sourcemap missing #742

Closed
wants to merge 2 commits into from

Conversation

windsonR
Copy link
Contributor

@windsonR windsonR commented Mar 8, 2024

Description

When user set their exclude option to an Array like [/aaa/,/bbb/]

User's exclude DO NOT contains node_modules/.vite or node_modules which is specified in default exclude array.

Then when Browser request pre-bundled file, plugin WILL transform them and generate a new sourcemap for them

The new sourcemap will override the original sourcemap generated by vite

Linked Issues

Additional context

@windsonR windsonR requested a review from antfu as a code owner March 8, 2024 08:35
Copy link

stackblitz bot commented Mar 8, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@antfu
Copy link
Member

antfu commented May 1, 2024

Thanks but this is by design. To allow users to have full control over what to include/exclude. The new implementation takes away the capability. Instead, we could expose some constant for defaultInlcudes and defaultExcludes

@antfu antfu closed this May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants