Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid ESLint path resolution errors on Windows #469

Merged
merged 21 commits into from
Nov 15, 2023
Merged

Avoid ESLint path resolution errors on Windows #469

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
0bae7f3
Install Preflight globally for Next.js project
karlhorky Nov 14, 2023
39284fe
Add `preflight` to path
karlhorky Nov 14, 2023
ee9a882
Run pnpm setup before adding globally
karlhorky Nov 14, 2023
911ab42
Set PNPM_HOME environment variable
karlhorky Nov 14, 2023
1884f88
Set $SHELL to 'bash'
karlhorky Nov 14, 2023
a2a3ed2
Add debugging
karlhorky Nov 14, 2023
2944359
Remove snapshots
karlhorky Nov 14, 2023
df3154c
Fix path
karlhorky Nov 14, 2023
0223133
Change path
karlhorky Nov 14, 2023
72de7e1
Shamefully hoist pnpm installed packages
karlhorky Nov 14, 2023
edc7360
Increase timeout
karlhorky Nov 14, 2023
3405f71
Skip CI steps on Windows
karlhorky Nov 14, 2023
42fa666
Always shamefully hoist
karlhorky Nov 15, 2023
e7f4f54
Switch to npm install
karlhorky Nov 15, 2023
66642f3
Only npm install on Windows
karlhorky Nov 15, 2023
b2c193b
Use node-linker=hoisted for ESLint
karlhorky Nov 15, 2023
4c9e084
Switch to tmpdir()
karlhorky Nov 15, 2023
71884c8
Revert other changes
karlhorky Nov 15, 2023
cb097b7
Reduce diff
karlhorky Nov 15, 2023
0cf5012
Fix path
karlhorky Nov 15, 2023
dd8aec7
Increase timeout running pnpm install for Windows
karlhorky Nov 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 6 additions & 0 deletions .github/workflows/build-lint-test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,15 +45,21 @@ jobs:

- run: pnpm install
- run: pnpm install
if: runner.os != 'Windows'
working-directory: docker

- name: Lint
if: runner.os != 'Windows'
run: pnpm lint

- run: pnpm tsc
if: runner.os != 'Windows'
- run: pnpm tsc --project bin/tsconfig.json
if: runner.os != 'Windows'
- run: pnpm tsc --project docker/tsconfig.json
if: runner.os != 'Windows'
- run: pnpm tsc --project tsconfig.nonsrc.json
if: runner.os != 'Windows'

- name: Build
run: pnpm build
Expand Down
18 changes: 13 additions & 5 deletions __tests__/e2e.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,16 @@
import { tmpdir } from 'node:os';
import { beforeAll, expect, test } from '@jest/globals';
import { execaCommand } from 'execa';
import pMap from 'p-map';

const fixturesTempDir = '__tests__/fixtures/__temp';
const fixturesTempDir = process.env.GITHUB_ACTIONS
? // Switch to `tmpdir()` on GitHub Actions to avoid
// ESLint crashing with Windows paths over the 260
// character MAX_PATH limit
// https://github.com/upleveled/preflight/pull/469/#issuecomment-1812422819
// https://github.com/eslint/eslint/issues/17763
tmpdir()
: '__tests__/fixtures/__temp';

function cloneRepoToFixtures(repoPath: string, fixtureDirName: string) {
return execaCommand(
Expand Down Expand Up @@ -79,8 +87,8 @@ beforeAll(
{ concurrency: 1 },
);
},
// 5 minute timeout for pnpm installation inside test repos
300000,
// 7.5 minute timeout for pnpm installation inside test repos
450000,
Comment on lines -82 to +91
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we have to increase the timeout because it takes longer for pnpm to install on Windows in tmpdir() apparently

);

function sortStdoutAndStripVersionNumber(stdout: string) {
Expand All @@ -97,7 +105,7 @@ function sortStdoutAndStripVersionNumber(stdout: string) {

test('Passes in the react-passing test project', async () => {
const { stdout, stderr } = await execaCommand(
`../../../../bin/preflight.js`,
`${process.cwd()}/bin/preflight.js`,
{
cwd: `${fixturesTempDir}/react-passing`,
},
Expand All @@ -109,7 +117,7 @@ test('Passes in the react-passing test project', async () => {

test('Passes in the next-js-passing test project', async () => {
const { stdout, stderr } = await execaCommand(
`../../../../bin/preflight.js`,
`${process.cwd()}/bin/preflight.js`,
{
cwd: `${fixturesTempDir}/next-js-passing`,
},
Expand Down