Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added support for IPv6 in GitHub Actions #904

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

titanism
Copy link

@titanism titanism commented Jan 7, 2024

Recently we submitted a PR for adding ipv6: true to the yaml config to check IPv6. However GitHub actions does not yet support IPv6 unfortunately. This PR is necessary as it uses Cloudflare WARP network configuration on the runner to add IPv6 support. See actions/runner-images#668 (comment) for more insight.

Recently we submitted a PR for adding `ipv6: true` to the yaml config to check IPv6.  However GitHub actions does not yet support IPv6 unfortunately.  This PR is necessary as it uses Cloudflare WARP network configuration on the runner to add IPv6 support.  See <actions/runner-images#668 (comment)> for more insight.
titanism added a commit to forwardemail/status.forwardemail.net that referenced this pull request Jan 7, 2024
titanism added a commit to forwardemail/status.forwardemail.net that referenced this pull request Jan 7, 2024
AnandChowdhary added a commit to upptime/uptime-monitor that referenced this pull request Jan 8, 2024
@AnandChowdhary
Copy link
Member

We can't update the workflows directly like this because they are generated in the code, but I'll added this feature here: upptime/uptime-monitor@e328be7. Please let me know if it works for you!

How I've set it up is that we detect whether there's any site with ipv6: true in your configuration, and if yes, we add the fscarmen/warp-on-actions workflow to the configuration file. This way, we don't add it unnecessarily to all configuration files that don't use an IPv6 repo.

@titanism
Copy link
Author

titanism commented Jan 8, 2024

Thank you, testing this out now.

titanism added a commit to forwardemail/status.forwardemail.net that referenced this pull request Jan 8, 2024
@titanism
Copy link
Author

titanism commented Jan 8, 2024

I don't think this is working @AnandChowdhary, I don't think it has any affect on "Uptime CI" job yet, which it should?

https://github.com/forwardemail/status.forwardemail.net/actions/runs/7451369909/workflow

You can see our IPv6 checks are failing still at https://status.forwardemail.net

@titanism
Copy link
Author

titanism commented Jan 8, 2024

@titanism
Copy link
Author

titanism commented Jan 8, 2024

Screenshot for visual sanity:
Screen Shot 2024-01-08 at 12 15 21 PM

Can you fix this and ping us back once new version is on npm? 🙏

titanism added a commit to forwardemail/status.forwardemail.net that referenced this pull request Jan 8, 2024
@AnandChowdhary
Copy link
Member

On it!

@AnandChowdhary
Copy link
Member

@titanism
Copy link
Author

titanism commented Jan 9, 2024

Thank you 🙏 will test

titanism added a commit to forwardemail/status.forwardemail.net that referenced this pull request Jan 9, 2024
titanism added a commit to forwardemail/status.forwardemail.net that referenced this pull request Jan 9, 2024
@titanism
Copy link
Author

@AnandChowdhary can you please simply just merge this PR instead of all the other work you're doing with custom yaml file generation? This is way more reliable for DNS checking anyways, as Cloudflare is way more reliable to use than whatever the default is for GitHub CI.

@AnandChowdhary
Copy link
Member

Hey @titanism, sorry for the delay here, I understand that it's annoying for it to not work and for you to have to wait.

The problem is that if we make any changes to the workflow here, like in your PR, they will be automatically overwritten when the next update happens, for example here -- forwardemail/status.forwardemail.net@275501d. So even if we want to remove the conditional and add this step to all workflows, it still needs to be added to the codebase in the workflows.ts file rather than here, as all workflows are programmatically generated.

I just tested it and "Update Template" ran as expected and made this commit 50520e9 after my commit adding your site in 5a830c4. But even after adding that step, the next run marks your site as down - https://github.com/upptime/upptime/actions/runs/7527414163/job/20487519591. Are you certain that adding this step should make it work?

@titanism
Copy link
Author

Interesting, Got an error (on error) [Error: Couldn't resolve host name] indicates IPv6 isn't working or wasn't configured correctly on GitHub CI. I don't see WARP (this PR) being setup in that CI though?

@AnandChowdhary
Copy link
Member

Can you please run "Update Template CI" manually, and then when it's done run "Setup CI"? Let' see if it works :)

titanism added a commit to forwardemail/status.forwardemail.net that referenced this pull request Jan 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants