fix: return flag state after evaluation #29
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When no percentage or rule is applied during evaluation, return the state of the flag instead of a fixed false.
Problem
When using the
getFlag
method on the Client class, the flag is evaluated. If no percentage or rules are present on the flag, a fixed false is returned instead of theenabled
property of the flag.Example:
Solution
Return
flag.enabled
instead offalse
at the end of the evaluation.