Fix logical error in cache eviction #30
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Equality has a higher precedence, and the direction of the validation operation was in the wrong direction (i.e., we want to check if now() has gone past the creation date)
|
@sinaa is attempting to deploy a commit to the Upstash Team on Vercel. A member of the Team first needs to authorize it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While testing the edge-flags sdk with some unit tests, I came to notice that the cache is never working.
Turned out that this was due to a logical error in the cache eviction condition.
Equality has a higher precedence, and the direction of the validation operation was in the wrong direction (i.e., we want to check if
now()has gone past the creation date + ttl).