Merge pull request #1126 from oleorhagen/reqflagerr

fix: Print the long options of the required flags missing
urfave · May 2, 2020 · 1e44266 · 1e44266
2 parents 053ba9d + ee2fae6
commit 1e44266
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 1 deletion.
diff --git a/context.go b/context.go
@@ -324,11 +324,12 @@ func checkRequiredFlags(flags []Flag, context *Context) requiredFlagsErr {
 			var flagPresent bool
 			var flagName string
 			for _, key := range strings.Split(f.GetName(), ",") {
+				key = strings.TrimSpace(key)
 				if len(key) > 1 {
 					flagName = key
 				}
 
-				if context.IsSet(strings.TrimSpace(key)) {
+				if context.IsSet(key) {
 					flagPresent = true
 				}
 			}

diff --git a/context_test.go b/context_test.go
@@ -576,6 +576,14 @@ func TestCheckRequiredFlags(t *testing.T) {
 			},
 			parseInput: []string{"-n", "asd", "-n", "qwe"},
 		},
+		{
+			testCase: "required_flag_with_short_alias_not_printed_on_error",
+			expectedAnError: true,
+			expectedErrorContents: []string{"Required flag \"names\" not set"},
+			flags: []Flag{
+				StringSliceFlag{Name: "names, n", Required: true},
+			},
+		},
 	}
 	for _, test := range tdata {
 		t.Run(test.testCase, func(t *testing.T) {