Merge pull request #1117 from creekorful/harmonize-error-handling

Harmonize BeforeError handling
urfave · Apr 28, 2020 · 464c868 · 464c868
2 parents 4bb97e0 + c261e4d
commit 464c868
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 3 deletions.
diff --git a/app.go b/app.go
@@ -292,8 +292,6 @@ func (a *App) RunContext(ctx context.Context, arguments []string) (err error) {
 	if a.Before != nil {
 		beforeErr := a.Before(context)
 		if beforeErr != nil {
-			_, _ = fmt.Fprintf(a.Writer, "%v\n\n", beforeErr)
-			_ = ShowAppHelp(context)
 			a.handleExitCoder(context, beforeErr)
 			err = beforeErr
 			return err

diff --git a/command.go b/command.go
@@ -150,7 +150,6 @@ func (c *Command) Run(ctx *Context) (err error) {
 	if c.Before != nil {
 		err = c.Before(context)
 		if err != nil {
-			_ = ShowCommandHelp(context, c.Name)
 			context.App.handleExitCoder(context, err)
 			return err
 		}