Merge pull request #1170 from tych0/fix-slice-mutation

*Slice: don't mutate the underlying default value
urfave · Aug 26, 2020 · af7fa3d · af7fa3d
2 parents fe4a429 + 7c493f6
commit af7fa3d
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 3 deletions.
diff --git a/flag_int64_slice.go b/flag_int64_slice.go
@@ -171,7 +171,9 @@ func lookupInt64Slice(name string, set *flag.FlagSet) []int64 {
 func removeFromInt64Slice(slice []int64, val int64) []int64 {
 	for i, v := range slice {
 		if v == val {
-			return append(slice[:i], slice[i+1:]...)
+			ret := append([]int64{}, slice[:i]...)
+			ret = append(ret, slice[i+1:]...)
+			return ret
 		}
 	}
 	return slice

diff --git a/flag_int_slice.go b/flag_int_slice.go
@@ -170,7 +170,9 @@ func lookupIntSlice(name string, set *flag.FlagSet) []int {
 func removeFromIntSlice(slice []int, val int) []int {
 	for i, v := range slice {
 		if v == val {
-			return append(slice[:i], slice[i+1:]...)
+			ret := append([]int{}, slice[:i]...)
+			ret = append(ret, slice[i+1:]...)
+			return ret
 		}
 	}
 	return slice

diff --git a/flag_string_slice.go b/flag_string_slice.go
@@ -156,7 +156,9 @@ func lookupStringSlice(name string, set *flag.FlagSet) []string {
 func removeFromStringSlice(slice []string, val string) []string {
 	for i, v := range slice {
 		if v == val {
-			return append(slice[:i], slice[i+1:]...)
+			ret := append([]string{}, slice[:i]...)
+			ret = append(ret, slice[i+1:]...)
+			return ret
 		}
 	}
 	return slice