Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved auto-completion instructions and added example gifs #1059

Merged
merged 1 commit into from Feb 6, 2020
Merged

Improved auto-completion instructions and added example gifs #1059

merged 1 commit into from Feb 6, 2020

Conversation

masonj5n
Copy link
Contributor

@masonj5n masonj5n commented Feb 6, 2020

What type of PR is this?

(REQUIRED)

  • bug
  • cleanup
  • documentation
  • feature

What this PR does / why we need it:

(REQUIRED)

This PR modifies manual.md in the v2 docs; it improves existing auto-completion documentation and adds new sections that clarify the different ways you can enable auto-completion. It also adds examples of what the different kinds of auto-completion look like.

Which issue(s) this PR fixes:

(REQUIRED)

Fixes #863

Release Notes

(REQUIRED)

NONE

@masonj5n masonj5n requested a review from a team as a code owner February 6, 2020 00:57
@masonj5n masonj5n requested review from saschagrunert and rliebz and removed request for a team February 6, 2020 00:57
@codecov
Copy link

codecov bot commented Feb 6, 2020

Codecov Report

Merging #1059 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1059   +/-   ##
=======================================
  Coverage   72.83%   72.83%           
=======================================
  Files          33       33           
  Lines        2474     2474           
=======================================
  Hits         1802     1802           
  Misses        565      565           
  Partials      107      107

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fed41d6...305e3de. Read the comment docs.

@daxmc99 daxmc99 mentioned this pull request Feb 6, 2020
4 tasks
Copy link
Member

@saschagrunert saschagrunert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I assume that the fish auto completion is fine for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bash completion: documentation not understandable
3 participants