Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs #1060

Closed
wants to merge 1 commit into from
Closed

Update docs #1060

wants to merge 1 commit into from

Conversation

daxmc99
Copy link

@daxmc99 daxmc99 commented Feb 6, 2020

What type of PR is this?

(REQUIRED)

  • bug
  • cleanup
  • documentation
  • feature

What this PR does / why we need it:

This PR adds better documentation for the autocomplete functionality of urfav/cli

The original work was performed in #905 by @masonj188.
This PR is that same work updated to prevent merge conflicts

Which issue(s) this PR fixes:

Fixes #863

@daxmc99 daxmc99 requested a review from a team as a code owner February 6, 2020 01:04
@daxmc99 daxmc99 requested review from saschagrunert and rliebz and removed request for a team February 6, 2020 01:04
@codecov
Copy link

codecov bot commented Feb 6, 2020

Codecov Report

Merging #1060 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1060   +/-   ##
=======================================
  Coverage   72.83%   72.83%           
=======================================
  Files          33       33           
  Lines        2474     2474           
=======================================
  Hits         1802     1802           
  Misses        565      565           
  Partials      107      107

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fed41d6...c534746. Read the comment docs.

@daxmc99
Copy link
Author

daxmc99 commented Feb 6, 2020

@lynncyrin PTAL

@daxmc99
Copy link
Author

daxmc99 commented Feb 6, 2020

Closing for #1059

@daxmc99 daxmc99 closed this Feb 6, 2020
@daxmc99 daxmc99 deleted the bash_complete branch February 6, 2020 03:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bash completion: documentation not understandable
1 participant