New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use a more k8s/release friendly PR template. #1035
Conversation
@lynncyrin All yours! |
Codecov Report
@@ Coverage Diff @@
## master #1035 +/- ##
======================================
Coverage 72.6% 72.6%
======================================
Files 33 33
Lines 2482 2482
======================================
Hits 1802 1802
Misses 569 569
Partials 111 111 Continue to review full report at Codecov.
|
I'm going to edit the PR description very slightly, since this PR shouldn't close #965 just yet 🙂 |
Done! ✅ |
Not sure why tests are failing? Someone please investigate 🙏 |
Ah, master is failing 🙁 #1037 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This should pass once the master is merged with this branch. |
Looks like this is good to go! |
What type of PR is this?
/kind documentation
What this PR does / why we need it:
Modifying the PR template will will enable easier parsing kubernetes release-notes tool (tracked in #965). The tool makes some assumptions about PR bodies so limiting drift between those assumptions and the PR template should make release note generation more reliable.
Which issue(s) this PR fixes:
Partially addresses #965
Special notes for your reviewer:
Tried to keep the spirit of the original template but I've made some sections "Required" if they are important to release notes generation. Also I assume the list of "allowed" labels has been updated (or will be) based on the labels in this template.