Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

go 1.14 #1085

Merged
merged 3 commits into from Mar 10, 2020
Merged

go 1.14 #1085

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
97faf22
Update cli.yml
coilysiren Mar 9, 2020
d7919f0
Update README.md
coilysiren Mar 9, 2020
f4ec4f6
Update README.md
coilysiren Mar 9, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
10 changes: 5 additions & 5 deletions .github/workflows/cli.yml
View file
Open in desktop
Expand Up @@ -16,7 +16,7 @@ jobs:
strategy:
matrix:
os: [ubuntu-latest, macos-latest, windows-latest]
go: [1.11, 1.12, 1.13]
go: [1.12, 1.13, 1.14]
name: ${{ matrix.os }} @ Go ${{ matrix.go }}
runs-on: ${{ matrix.os }}
steps:
Expand All @@ -39,7 +39,7 @@ jobs:
ref: ${{ github.ref }}

- name: GOFMT Check
if: matrix.go == 1.13 && matrix.os == 'ubuntu-latest'
if: matrix.go == 1.14 && matrix.os == 'ubuntu-latest'
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At someone point someone should change this to go-latest 🙂

run: test -z $(gofmt -l .)

- name: vet
Expand All @@ -52,7 +52,7 @@ jobs:
run: go run internal/build/build.go check-binary-size

- name: Upload coverage to Codecov
if: success() && matrix.go == 1.13 && matrix.os == 'ubuntu-latest'
if: success() && matrix.go == 1.14 && matrix.os == 'ubuntu-latest'
uses: codecov/codecov-action@v1
with:
token: 0a8cc73b-bb7c-480b-8626-38a461643761
Expand All @@ -62,10 +62,10 @@ jobs:
name: test-docs
runs-on: ubuntu-latest
steps:
- name: Set up Go 1.13
- name: Set up Go 1.14
uses: actions/setup-go@v1
with:
go-version: 1.13
go-version: 1.14

- name: Use Node.js 12.x
uses: actions/setup-node@v1
Expand Down
6 changes: 3 additions & 3 deletions README.md
View file
Open in desktop
Expand Up @@ -19,9 +19,9 @@ Usage documentation exists for each major version. Don't know what version you'r

## Installation

Make sure you have a working Go environment. Go version 1.11+ is supported. [See the install instructions for Go](http://golang.org/doc/install.html).
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I missed this line when originally making this PR, so I removed the go 1.11 reference here!

Using this package requires a working Go environment. [See the install instructions for Go](http://golang.org/doc/install.html).

Go Modules are strongly recommended when using this package. [See the go blog guide on using Go Modules](https://blog.golang.org/using-go-modules).
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Go modules are production ready now, I think it's safe to make this statement stronger

Go Modules are required when using this package. [See the go blog guide on using Go Modules](https://blog.golang.org/using-go-modules).

### Using `v2` releases

Expand Down Expand Up @@ -63,4 +63,4 @@ export PATH=$PATH:$GOPATH/bin

cli is tested against multiple versions of Go on Linux, and against the latest
released version of Go on OS X and Windows. This project uses Github Actions for
builds. For more build info, please look at the [./.github/workflows/cli.yml](https://github.com/urfave/cli/blob/master/.github/workflows/cli.yml).
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed this to explicitly mention that you can look at the ci config for go version testing info

builds. To see our currently supported go versions and platforms, look at the [./.github/workflows/cli.yml](https://github.com/urfave/cli/blob/master/.github/workflows/cli.yml).