Reqflagr #1129
Merged
Reqflagr #1129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a test verifying that the requiredFlagsError does contain the long option of the missing flag, instead of the short option and a space, which was the old behaviour. Signed-off-by: Ole Petter <ole.orhagen@northern.tech> (cherry picked from commit f842187)
oleorhagen
requested review from
saschagrunert and
asahasrabuddhe
and removed request for
a team
StringSliceFlag needs to be a pointer, and not a struct. Also formatted the test. See: urfave#1126 for a description of the regression tested for. Signed-off-by: Ole Petter <ole.orhagen@northern.tech>
|
See comment: #1126 (comment) for an explanation If not @rliebz will handle it directly. |
coilysiren
approved these changes
May 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Port of a regression test from v1
-[x] test
What this PR does / why we need it:
Which issue(s) this PR fixes:
(REQUIRED)
Special notes for your reviewer:
(fill-in or delete this section)
Testing
Tests that missing required flags will result in the long option being stored in the error message in
requiredFlagsErrRelease Notes
(REQUIRED)