StringSlice flags set to default Value

[darren-west]

StringSliceFlag types do not set the destination to the value if no env/arg is set.

For example if the argument --arg is not set and env variable ARG is not set you would expect the destination to be set to cli.NewStringSlice("foo")

                 var arg = cli.NewStringSlice()
		...
                  &cli.StringSliceFlag{
			Name:        "arg",
			EnvVars:     []string{"ARG"},
			Value:       cli.NewStringSlice("foo"),
			Destination: arg,
		},

I have quickly looked at how the string flag achieves this and tried to do similar.

[coilysiren]

Can you add a test to demonstrate the impact of this change?

[darren-west]

I have added a test. The idea is that if the destination is set and the value is set but the flag is not set by env name or a program argument the value sets the destination. This is more consistent with how the other flags work (for instance StringFlag)

[erikwilson]

It looks like this is a duplicate of #1127?

[coilysiren]

It does look like this is a duplicate!

[stale]

This issue or PR has been automatically marked as stale because it has not had recent activity. Please add a comment bumping this if you're still interested in it's resolution! Thanks for your help, please let us know if you need anything else.

[stale]

Closing this as it has become stale.

[meatballhat]

Confirmed already fixed via #1127

Thank you all the same @darren-west!