Commits on Aug 5, 2020

1. *Slice: don't mutate the underlying default value …

   If the default value is present, we shouldn't mutate it. Appending slices
   as the code was before mutates the underlying value:
   
   package main
   
   import (
   	"fmt"
   )
   
   func main() {
   	slice := []string{"a", "b", "c"}
   
   	fmt.Println(append(slice[:1], slice[2:]...))
   	fmt.Println(slice)
   }
   ~ go run tester2.go
   [a c]
   [a c c]
   
   Let's fix this by creating and returning an entirely new slice.
   
   Closes urfave#1169
   
   Signed-off-by: Tycho Andersen <tycho@tycho.ws>

   

   tych0 committed Aug 5, 2020
   Copy the full SHA

   7c493f6 View commit details

   Browse the repository at this point in the history