Remove reflect calls for doc generation #1259
Merged
+240
−48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dearchap
requested review from
saschagrunert and
asahasrabuddhe
and removed request for
a team
dearchap
force-pushed
the
remove_reflect
branch
from
3f08bd4 to
7cd7ff7
Compare
|
This issue or PR has been automatically marked as stale because it has not had recent activity. Please add a comment bumping this if you're still interested in it's resolution! Thanks for your help, please let us know if you need anything else. |
|
Closing this as it has become stale. |
|
This issue or PR has been bumped and is no longer marked as stale! Feel free to bump it again in the future, if it's still relevant. |
meatballhat
added
area/v2
meatballhat
added a commit
that referenced
this pull request
Apr 22, 2022
Remove reflect calls for doc generation (#1259)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
Instead of using reflection to figure out values of fields, the doc generation interface has been extended to include everything needed to stringify a flag. Custom flags need to properly implement the interface to get the valid synopsis for flags
Which issue(s) this PR fixes:
Fixes #631
Special notes for your reviewer:
Since the SliceFlags were type checked in the stringify(Flag) function it makes more sense to move those directly to the individual flags
Testing
go test ./...
Release Notes
DocGenerationFlag has bee extended and all currently defined flag type have been modified to use this interface. This allows doc generation to be customizable without having to resort to reflection