Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for alias in YAMLs #1448

Merged
merged 14 commits into from Aug 30, 2022
Merged

Add support for alias in YAMLs #1448

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
55f2a9a
adding in boolean alias support
james-prysm Aug 11, 2022
e767f7c
fixing formatting
james-prysm Aug 11, 2022
88bc9e5
Merge branch 'main' into alias-support
james-prysm Aug 15, 2022
f576fbf
Merge branch 'main' into alias-support
james-prysm Aug 17, 2022
fb2bedf
Merge branch 'main' into alias-support
Dokiys Aug 24, 2022
7a8daa4
Merge branch 'main' into alias-support
james-prysm Aug 25, 2022
a4c7af1
adding string alias and test
james-prysm Aug 25, 2022
b225dba
adding int alias and test
james-prysm Aug 25, 2022
4238aa1
add support for duration flag
james-prysm Aug 25, 2022
af5a5d5
adding float flag alias support
james-prysm Aug 25, 2022
3280b9e
adding alias support to remaining flags and fixing tests
james-prysm Aug 25, 2022
9c02a7a
fixing test
james-prysm Aug 25, 2022
fc59b73
Merge branch 'main' into alias-support
james-prysm Aug 29, 2022
843599a
Modify nesting flag apply
Aug 30, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
20 changes: 12 additions & 8 deletions altsrc/flag.go
View file
Open in desktop
Expand Up @@ -121,14 +121,18 @@ func (f *IntSliceFlag) ApplyInputSourceValue(cCtx *cli.Context, isc InputSourceC

// ApplyInputSourceValue applies a Bool value to the flagSet if required
func (f *BoolFlag) ApplyInputSourceValue(cCtx *cli.Context, isc InputSourceContext) error {
if f.set != nil && !cCtx.IsSet(f.Name) && !isEnvVarSet(f.EnvVars) && isc.isSet(f.BoolFlag.Name) {
value, err := isc.Bool(f.BoolFlag.Name)
if err != nil {
return err
}
if value {
for _, name := range f.Names() {
_ = f.set.Set(name, strconv.FormatBool(value))
if f.set != nil && !cCtx.IsSet(f.Name) && !isEnvVarSet(f.EnvVars) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dearchap @james-prysm Do you think there is too mush nesting? Should we return early when don't need to handle. For example:

	if f.set == nil || cCtx.IsSet(f.Name) || isEnvVarSet(f.EnvVars) {
		return nil
	}
	for _, name := range f.BoolFlag.Names() {
		if !isc.isSet(name) {
			continue
		}
		value, err := isc.Bool(name)
		if err != nil {
			return err
		}
		for _, n := range f.Names() {
			_ = f.set.Set(n, strconv.FormatBool(value))
		}
	}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Dokiys definitely your approach is more readable. You want to make the changes and push ?

for _, name := range f.BoolFlag.Names() {
if isc.isSet(name) {
value, err := isc.Bool(name)
if err != nil {
return err
}
if value {
for _, n := range f.Names() {
_ = f.set.Set(n, strconv.FormatBool(value))
}
}
}
}
}
Expand Down
13 changes: 13 additions & 0 deletions altsrc/flag_test.go
View file
Open in desktop
Expand Up @@ -178,6 +178,19 @@ func TestBoolApplyInputSourceMethodSet(t *testing.T) {
refute(t, true, c.Bool("test"))
}

func TestBoolApplyInputSourceMethodSet_Alias(t *testing.T) {
tis := testApplyInputSource{
Flag: NewBoolFlag(&cli.BoolFlag{Name: "test", Aliases: []string{"test_alias"}}),
FlagName: "test_alias",
MapValue: true,
}
c := runTest(t, tis)
expect(t, true, c.Bool("test_alias"))

c = runRacyTest(t, tis)
refute(t, true, c.Bool("test_alias"))
}

func TestBoolApplyInputSourceMethodContextSet(t *testing.T) {
tis := testApplyInputSource{
Flag: NewBoolFlag(&cli.BoolFlag{Name: "test"}),
Expand Down