Build and run urfave-cli-genflags via its Makefile
#1526
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
so that `go.mod` files don't get all confused
meatballhat
added
kind/bug
|
Can this help avoid |
|
@abitrolly I don't think so (?) If anything, I'm adding more dependence on |
|
I see. If that doesn't affect |
1 task
Dokiys
approved these changes
Oct 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
Without this, running
make generatecan result in errors about missinggithub.com/urfave/cli/v2because the top-levelgo.modcontext is in use rather than thecmd/urfave-cli-genflags/go.mod.For example, this failure in the
v3-portingbranch: https://github.com/urfave/cli/actions/runs/3214832631/jobs/5255497140Which issue(s) this PR fixes:
NA 馃槵