Feature: (issue_1451) customized slice flag separator #1546
Conversation
FGYFFFF
force-pushed
the
feat/disable_split_parameters_for_slice_flag
branch
from
53f1b5e
to
2d390e9
Compare
FGYFFFF
changed the title
|
The setting of "SliceFlagSeparator" is "global-level" because it is necessary to keep the same separator for each "sliceFlag". Therefore it is not set to "flag-level" |
FGYFFFF
force-pushed
the
feat/disable_split_parameters_for_slice_flag
branch
8 times, most recently
from
b012801
to
ba36536
Compare
|
@dearchap Please help me, why does "CI" keep failing?😭 |
|
Can you do a gofmt or goimports in main dir ? |
FGYFFFF
force-pushed
the
feat/disable_split_parameters_for_slice_flag
branch
from
ba36536
to
c3675c0
Compare
I did gofmt&goimports for the "flag_test.go" file, but it still failed. |
FGYFFFF
force-pushed
the
feat/disable_split_parameters_for_slice_flag
branch
7 times, most recently
from
dffd74a
to
f71906f
Compare
FGYFFFF
force-pushed
the
feat/disable_split_parameters_for_slice_flag
branch
5 times, most recently
from
282d0a0
to
2f10ac7
Compare
|
@dearchap Please help me review the code, I rely on this feature to do my work！💕💕💕 |
FGYFFFF
force-pushed
the
feat/disable_split_parameters_for_slice_flag
branch
from
2f10ac7
to
c5da5f6
Compare
FGYFFFF
changed the title
flag_test.go
Outdated
| } | ||
|
|
||
| _ = app.Run(os.Args) | ||
| defaultSliceFlagSeparator = "," |
There was a problem hiding this comment.
better to add the revert of defaultSliceFlagSeparator in a defer
flag_test.go
Outdated
| } | ||
| app.SliceFlagSeparator = ";" | ||
| app.Action = func(ctx *Context) error { | ||
| ret := ctx.StringSlice("stringSlice") |
There was a problem hiding this comment.
its better not to rely on Action here. If action doesnt get called the test would pass. why dont you set the destination filed of the string slice flag and then validate the slice contents
FGYFFFF
force-pushed
the
feat/disable_split_parameters_for_slice_flag
branch
from
ad7dfde
to
957957f
Compare
What type of PR is this?
feature
(REQUIRED)
What this PR does / why we need it:
add customized slice flag separator
(REQUIRED)
Which issue(s) this PR fixes:
Feature #1541
(REQUIRED)
Special notes for your reviewer:
(fill-in or delete this section)
Testing
(fill-in or delete this section)
Release Notes
(REQUIRED)