Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make *cli.Context implement context.Context by renaming Value #1597

Open
wants to merge 268 commits into
base: v2-maint
Choose a base branch
from
Open

Make *cli.Context implement context.Context by renaming Value #1597

wants to merge 268 commits into from
This pull request is big! We’re only showing the most recent 250 commits.

Commits on Oct 2, 2022

  1. Tidy up top-level go.mod

    @meatballhat
    meatballhat committed Oct 2, 2022
    Configuration menu
    Copy the full SHA
    d8de3b5 View commit details
    Browse the repository at this point in the history

  2. Add missing go.sum entries for go 1.16.x

    @meatballhat
    meatballhat committed Oct 2, 2022
    Configuration menu
    Copy the full SHA
    a5313eb View commit details
    Browse the repository at this point in the history

  3. Turn off docs publishing from v3 series

    @meatballhat
    meatballhat committed Oct 2, 2022
    Configuration menu
    Copy the full SHA
    67b3de0 View commit details
    Browse the repository at this point in the history

  4. Use goimports as formatting standard 

    given some disagreement with gofmt that seems to have shown up in 1.19
    @meatballhat
    meatballhat committed Oct 2, 2022
    Configuration menu
    Copy the full SHA
    cbc7f1a View commit details
    Browse the repository at this point in the history

  5. Shift supported go versions 

    and approve word-wrapping changes to godoc
    @meatballhat
    meatballhat committed Oct 2, 2022
    Configuration menu
    Copy the full SHA
    76bb9f1 View commit details
    Browse the repository at this point in the history

  6. split v1 docs into individual pages

    @hay-kot @meatballhat
    hay-kot authored and meatballhat committed Oct 2, 2022
    Configuration menu
    Copy the full SHA
    1ae70fc View commit details
    Browse the repository at this point in the history

  7. breakup v2 documentation

    @hay-kot @meatballhat
    hay-kot authored and meatballhat committed Oct 2, 2022
    Configuration menu
    Copy the full SHA
    edaf885 View commit details
    Browse the repository at this point in the history

  8. update sidebar configuration

    @hay-kot @meatballhat
    hay-kot authored and meatballhat committed Oct 2, 2022
    Configuration menu
    Copy the full SHA
    18f8e6d View commit details
    Browse the repository at this point in the history

  9. add tags plugin

    @hay-kot @meatballhat
    hay-kot authored and meatballhat committed Oct 2, 2022
    Configuration menu
    Copy the full SHA
    7cfafe8 View commit details
    Browse the repository at this point in the history

  10. add tags and boost for pages

    @hay-kot @meatballhat
    hay-kot authored and meatballhat committed Oct 2, 2022
    Configuration menu
    Copy the full SHA
    8036eac View commit details
    Browse the repository at this point in the history

  11. wip: add --walk flag to gfrun to accept directory

    @hay-kot @meatballhat
    hay-kot authored and meatballhat committed Oct 2, 2022
    Configuration menu
    Copy the full SHA
    d217a5a View commit details
    Browse the repository at this point in the history

  12. pass in correct root

    @hay-kot @meatballhat
    hay-kot authored and meatballhat committed Oct 2, 2022
    Configuration menu
    Copy the full SHA
    87f003f View commit details
    Browse the repository at this point in the history

  13. rename filename to dirPath

    @hay-kot @meatballhat
    hay-kot authored and meatballhat committed Oct 2, 2022
    Configuration menu
    Copy the full SHA
    2b1a8ca View commit details
    Browse the repository at this point in the history

  14. Fix:(issue_1094) Dont execute Before/After handlers during shell comp… 

    …letion
    @dearchap @meatballhat
    dearchap authored and meatballhat committed Oct 2, 2022
    Configuration menu
    Copy the full SHA
    42d8058 View commit details
    Browse the repository at this point in the history

  15. Rename function

    @dearchap @meatballhat
    dearchap authored and meatballhat committed Oct 2, 2022
    Configuration menu
    Copy the full SHA
    42eb492 View commit details
    Browse the repository at this point in the history

  16. Fix:(issue_1455) Allow bool flags from input altsrc

    @dearchap @meatballhat
    dearchap authored and meatballhat committed Oct 2, 2022
    Configuration menu
    Copy the full SHA
    78dac9c View commit details
    Browse the repository at this point in the history

  17. Remove debug println

    @dearchap @meatballhat
    dearchap authored and meatballhat committed Oct 2, 2022
    Configuration menu
    Copy the full SHA
    3c6588c View commit details
    Browse the repository at this point in the history

  18. Revert godoc changes

    @dearchap @meatballhat
    dearchap authored and meatballhat committed Oct 2, 2022
    Configuration menu
    Copy the full SHA
    f515798 View commit details
    Browse the repository at this point in the history

  19. Add configurable Base to int, uint and uint64 flags 

    This allows users to configure the basis for integer parsing.
    @ccremer @meatballhat
    ccremer authored and meatballhat committed Oct 2, 2022
    Configuration menu
    Copy the full SHA
    382386a View commit details
    Browse the repository at this point in the history

  20. fix: allow required flag with one character

    @Gerrard-YNWA @meatballhat
    Gerrard-YNWA authored and meatballhat committed Oct 2, 2022
    Configuration menu
    Copy the full SHA
    9de6fa4 View commit details
    Browse the repository at this point in the history

  21. fix: update test case

    @Gerrard-YNWA @meatballhat
    Gerrard-YNWA authored and meatballhat committed Oct 2, 2022
    Configuration menu
    Copy the full SHA
    9092325 View commit details
    Browse the repository at this point in the history

  22. adding in boolean alias support

    @james-prysm @meatballhat
    james-prysm authored and meatballhat committed Oct 2, 2022
    Configuration menu
    Copy the full SHA
    e0db267 View commit details
    Browse the repository at this point in the history

  23. adding string alias and test

    @james-prysm @meatballhat
    james-prysm authored and meatballhat committed Oct 2, 2022
    Configuration menu
    Copy the full SHA
    50bbb4a View commit details
    Browse the repository at this point in the history

  24. adding int alias and test

    @james-prysm @meatballhat
    james-prysm authored and meatballhat committed Oct 2, 2022
    Configuration menu
    Copy the full SHA
    5a5789a View commit details
    Browse the repository at this point in the history

  25. add support for duration flag

    @james-prysm @meatballhat
    james-prysm authored and meatballhat committed Oct 2, 2022
    Configuration menu
    Copy the full SHA
    c512a28 View commit details
    Browse the repository at this point in the history

  26. adding float flag alias support

    @james-prysm @meatballhat
    james-prysm authored and meatballhat committed Oct 2, 2022
    Configuration menu
    Copy the full SHA
    126d238 View commit details
    Browse the repository at this point in the history

  27. adding alias support to remaining flags and fixing tests

    @james-prysm @meatballhat
    james-prysm authored and meatballhat committed Oct 2, 2022
    Configuration menu
    Copy the full SHA
    9630e10 View commit details
    Browse the repository at this point in the history

  28. fixing test

    @james-prysm @meatballhat
    james-prysm authored and meatballhat committed Oct 2, 2022
    Configuration menu
    Copy the full SHA
    9a33ae8 View commit details
    Browse the repository at this point in the history

  29. Modify nesting flag apply

    @meatballhat
    Dokiy authored and meatballhat committed Oct 2, 2022
    Configuration menu
    Copy the full SHA
    d520bfc View commit details
    Browse the repository at this point in the history

  30. Update v2 dead link

    @abousselmi @meatballhat
    abousselmi authored and meatballhat committed Oct 2, 2022
    Configuration menu
    Copy the full SHA
    445734d View commit details
    Browse the repository at this point in the history

  31. Fix:(issue_1293) Wrap usage text for commands

    @dearchap @meatballhat
    dearchap authored and meatballhat committed Oct 2, 2022
    Configuration menu
    Copy the full SHA
    b539ee7 View commit details
    Browse the repository at this point in the history

  32. Change way to calculate offset

    @dearchap @meatballhat
    dearchap authored and meatballhat committed Oct 2, 2022
    Configuration menu
    Copy the full SHA
    d89bc4a View commit details
    Browse the repository at this point in the history

  33. Make test case more robust

    @dearchap @meatballhat
    dearchap authored and meatballhat committed Oct 2, 2022
    Configuration menu
    Copy the full SHA
    96e41a6 View commit details
    Browse the repository at this point in the history

  34. Remove add function

    @dearchap @meatballhat
    dearchap authored and meatballhat committed Oct 2, 2022
    Configuration menu
    Copy the full SHA
    e48d377 View commit details
    Browse the repository at this point in the history

  35. Add comment

    @dearchap @meatballhat
    dearchap authored and meatballhat committed Oct 2, 2022
    Configuration menu
    Copy the full SHA
    321d493 View commit details
    Browse the repository at this point in the history

  36. Add App.UnknownFlagHandler

    @icholy @meatballhat
    icholy authored and meatballhat committed Oct 2, 2022
    Configuration menu
    Copy the full SHA
    6331815 View commit details
    Browse the repository at this point in the history

  37. Rename App.UnknownFlagHandler to App.InvalidFlagAccessHandler

    @icholy @meatballhat
    icholy authored and meatballhat committed Oct 2, 2022
    Configuration menu
    Copy the full SHA
    e19a34c View commit details
    Browse the repository at this point in the history

  38. Traverse parent contexts

    @icholy @meatballhat
    icholy authored and meatballhat committed Oct 2, 2022
    Configuration menu
    Copy the full SHA
    4bce542 View commit details
    Browse the repository at this point in the history

Commits on Oct 3, 2022

  1. Merge pull request urfave#1511 from urfave/v3-docs-off 

    Turn off docs publishing from v3 series
    @meatballhat
    meatballhat committed Oct 3, 2022
    Configuration menu
    Copy the full SHA
    a529996 View commit details
    Browse the repository at this point in the history

  2. Merge pull request urfave#1494 from urfave/v3-mod-bump 

    Bump declared module and internal usage to `/v3/`
    @meatballhat
    meatballhat committed Oct 3, 2022
    Configuration menu
    Copy the full SHA
    bd44c95 View commit details
    Browse the repository at this point in the history

  3. Fix:(issue_1272) Generic flag not set from env

    @dearchap @meatballhat
    dearchap authored and meatballhat committed Oct 3, 2022
    Configuration menu
    Copy the full SHA
    68cd3e8 View commit details
    Browse the repository at this point in the history

  4. Merge remote-tracking branch 'origin/v3-dev-main' into v3-porting

    @meatballhat
    meatballhat committed Oct 3, 2022
    Configuration menu
    Copy the full SHA
    d34a232 View commit details
    Browse the repository at this point in the history

  5. Use cli/v2 in genflags tool (for now?)

    @meatballhat
    meatballhat committed Oct 3, 2022
    Configuration menu
    Copy the full SHA
    1446649 View commit details
    Browse the repository at this point in the history

  6. Update cli.yml 

    Signed-off-by: sashashura <93376818+sashashura@users.noreply.github.com>
    @sashashura @meatballhat
    sashashura authored and meatballhat committed Oct 3, 2022
    Configuration menu
    Copy the full SHA
    e57f53b View commit details
    Browse the repository at this point in the history

  7. Update version of codecov action 

    given errors seen in other PRs using v2
    @meatballhat
    meatballhat committed Oct 3, 2022
    Configuration menu
    Copy the full SHA
    8609031 View commit details
    Browse the repository at this point in the history

  8. Explicitly pass CODECOV_TOKEN

    @meatballhat
    meatballhat committed Oct 3, 2022
    Configuration menu
    Copy the full SHA
    31edfd6 View commit details
    Browse the repository at this point in the history

  9. Add a few notes to release docs 

    about the relationship to proxy.golang.org and automatically generated
release notes.
    @meatballhat
    meatballhat committed Oct 3, 2022
    Configuration menu
    Copy the full SHA
    eea567a View commit details
    Browse the repository at this point in the history

  10. Add count option for bool flags

    @dearchap @meatballhat
    dearchap authored and meatballhat committed Oct 3, 2022
    Configuration menu
    Copy the full SHA
    03487fc View commit details
    Browse the repository at this point in the history

  11. Merge changes onto latest main

    @dearchap @meatballhat
    dearchap authored and meatballhat committed Oct 3, 2022
    Configuration menu
    Copy the full SHA
    2941bc8 View commit details
    Browse the repository at this point in the history

  12. Remove go changes

    @dearchap @meatballhat
    dearchap authored and meatballhat committed Oct 3, 2022
    Configuration menu
    Copy the full SHA
    c4251de View commit details
    Browse the repository at this point in the history

  13. Update for build

    @dearchap @meatballhat
    dearchap authored and meatballhat committed Oct 3, 2022
    Configuration menu
    Copy the full SHA
    2b0db3b View commit details
    Browse the repository at this point in the history

  14. Merge main and run tidy

    @dearchap @meatballhat
    dearchap authored and meatballhat committed Oct 3, 2022
    Configuration menu
    Copy the full SHA
    c0a2866 View commit details
    Browse the repository at this point in the history

  15. Rebase main

    @dearchap @meatballhat
    dearchap authored and meatballhat committed Oct 3, 2022
    Configuration menu
    Copy the full SHA
    2f082d6 View commit details
    Browse the repository at this point in the history

  16. Add to docs

    @dearchap @meatballhat
    dearchap authored and meatballhat committed Oct 3, 2022
    Configuration menu
    Copy the full SHA
    2f66431 View commit details
    Browse the repository at this point in the history

  17. Update docs

    @dearchap @meatballhat
    dearchap authored and meatballhat committed Oct 3, 2022
    Configuration menu
    Copy the full SHA
    b694a25 View commit details
    Browse the repository at this point in the history

  18. Update godocs

    @dearchap @meatballhat
    dearchap authored and meatballhat committed Oct 3, 2022
    Configuration menu
    Copy the full SHA
    cbd62ef View commit details
    Browse the repository at this point in the history

  19. Add args

    @dearchap @meatballhat
    dearchap authored and meatballhat committed Oct 3, 2022
    Configuration menu
    Copy the full SHA
    3adf8fa View commit details
    Browse the repository at this point in the history

  20. Update docs/v2/examples/flags.md 

    Co-authored-by: Dan Buch <dan@meatballhat.com>
    @dearchap @meatballhat
    dearchap and meatballhat committed Oct 3, 2022
    Configuration menu
    Copy the full SHA
    fa3bbf9 View commit details
    Browse the repository at this point in the history

  21. Add context.Count

    @dearchap @meatballhat
    dearchap authored and meatballhat committed Oct 3, 2022
    Configuration menu
    Copy the full SHA
    c0a8506 View commit details
    Browse the repository at this point in the history

  22. Add parametrize tests

    @dearchap @meatballhat
    dearchap authored and meatballhat committed Oct 3, 2022
    Configuration menu
    Copy the full SHA
    6b0a3e8 View commit details
    Browse the repository at this point in the history

  23. Add countable interface

    @dearchap @meatballhat
    dearchap authored and meatballhat committed Oct 3, 2022
    Configuration menu
    Copy the full SHA
    a509290 View commit details
    Browse the repository at this point in the history

  24. Remove keystroke errors

    @dearchap @meatballhat
    dearchap authored and meatballhat committed Oct 3, 2022
    Configuration menu
    Copy the full SHA
    d58b3c7 View commit details
    Browse the repository at this point in the history

  25. Merge changes from main

    @dearchap @meatballhat
    dearchap authored and meatballhat committed Oct 3, 2022
    Configuration menu
    Copy the full SHA
    fdcbf28 View commit details
    Browse the repository at this point in the history

  26. Rebase

    @dearchap @meatballhat
    dearchap authored and meatballhat committed Oct 3, 2022
    Configuration menu
    Copy the full SHA
    0764ca2 View commit details
    Browse the repository at this point in the history

  27. Fix tests per latest main

    @dearchap @meatballhat
    dearchap authored and meatballhat committed Oct 3, 2022
    Configuration menu
    Copy the full SHA
    7097d0e View commit details
    Browse the repository at this point in the history

  28. Fix formatting

    @dearchap @meatballhat
    dearchap authored and meatballhat committed Oct 3, 2022
    Configuration menu
    Copy the full SHA
    7405a90 View commit details
    Browse the repository at this point in the history

  29. Merge from main

    @dearchap @meatballhat
    dearchap authored and meatballhat committed Oct 3, 2022
    Configuration menu
    Copy the full SHA
    9bcffd0 View commit details
    Browse the repository at this point in the history

  30. Add coverage threshold

    @dearchap @meatballhat
    dearchap authored and meatballhat committed Oct 3, 2022
    Configuration menu
    Copy the full SHA
    2a5960c View commit details
    Browse the repository at this point in the history

  31. Add additional test to fix codecov

    @dearchap @meatballhat
    dearchap authored and meatballhat committed Oct 3, 2022
    Configuration menu
    Copy the full SHA
    5b96605 View commit details
    Browse the repository at this point in the history

  32. Add additional test to fix codecov

    @dearchap @meatballhat
    dearchap authored and meatballhat committed Oct 3, 2022
    Configuration menu
    Copy the full SHA
    9c5b385 View commit details
    Browse the repository at this point in the history

  33. Set codecov status thresholds to 5% 

    and rename file to be less dotty
    @meatballhat
    meatballhat committed Oct 3, 2022
    Configuration menu
    Copy the full SHA
    0658d61 View commit details
    Browse the repository at this point in the history

  34. Fix: dont generate pointer for dest for Generic flag

    @dearchap @meatballhat
    dearchap authored and meatballhat committed Oct 3, 2022
    Configuration menu
    Copy the full SHA
    e13c16b View commit details
    Browse the repository at this point in the history

  35. Fix: Help name consistency among app/commands and subcommands

    @dearchap @meatballhat
    dearchap authored and meatballhat committed Oct 3, 2022
    Configuration menu
    Copy the full SHA
    8e3fa06 View commit details
    Browse the repository at this point in the history

  36. Move more functionality into internal/build/build.go 

    and use make targets in CI, pass flag spec YAML through yq

includes result of running `make v2approve`
    @meatballhat
    meatballhat committed Oct 3, 2022
    Configuration menu
    Copy the full SHA
    8cc0a9c View commit details
    Browse the repository at this point in the history

  37. Run make target after the Makefile is available

    @meatballhat
    meatballhat committed Oct 3, 2022
    Configuration menu
    Copy the full SHA
    d9d960a View commit details
    Browse the repository at this point in the history

  38. Use windows compatible path append

    @meatballhat
    meatballhat committed Oct 3, 2022
    Configuration menu
    Copy the full SHA
    2bec081 View commit details
    Browse the repository at this point in the history

  39. Only run make v2diff on go 1.19.x + ubuntu-latest

    @meatballhat
    meatballhat committed Oct 3, 2022
    Configuration menu
    Copy the full SHA
    0593812 View commit details
    Browse the repository at this point in the history

  40. Replace a few more custom make targets

    @meatballhat
    meatballhat committed Oct 3, 2022
    Configuration menu
    Copy the full SHA
    d6c9f6a View commit details
    Browse the repository at this point in the history

  41. Use correct env var for global flags

    @meatballhat
    meatballhat committed Oct 3, 2022
    Configuration menu
    Copy the full SHA
    9ed5a09 View commit details
    Browse the repository at this point in the history

  42. Accept the MKDOCS_REMOTE_GITHUB_TOKEN var as intended

    @meatballhat
    meatballhat committed Oct 3, 2022
    Configuration menu
    Copy the full SHA
    1c3ebfa View commit details
    Browse the repository at this point in the history

  43. Fix:(issue_1197) Set destination field from altsrc for slice flags

    @dearchap @meatballhat
    dearchap authored and meatballhat committed Oct 3, 2022
    Configuration menu
    Copy the full SHA
    d2acd0e View commit details
    Browse the repository at this point in the history

  44. Add unit tests

    @dearchap @meatballhat
    dearchap authored and meatballhat committed Oct 3, 2022
    Configuration menu
    Copy the full SHA
    e9e87f6 View commit details
    Browse the repository at this point in the history

  45. fix: Context.Set no such flag

    @meatballhat
    torwang authored and meatballhat committed Oct 3, 2022
    Configuration menu
    Copy the full SHA
    a2c3729 View commit details
    Browse the repository at this point in the history

  46. feat: flag action

    @xwjdsh @meatballhat
    xwjdsh authored and meatballhat committed Oct 3, 2022
    Configuration menu
    Copy the full SHA
    e2e14ec View commit details
    Browse the repository at this point in the history

  47. Add more tests about flag-level action

    @xwjdsh @meatballhat
    xwjdsh authored and meatballhat committed Oct 3, 2022
    Configuration menu
    Copy the full SHA
    f9ceca5 View commit details
    Browse the repository at this point in the history

  48. Rebase main, update flag-spec.yaml to add Action field

    @xwjdsh @meatballhat
    xwjdsh authored and meatballhat committed Oct 3, 2022
    Configuration menu
    Copy the full SHA
    d213683 View commit details
    Browse the repository at this point in the history

  49. make v2approve

    @xwjdsh @meatballhat
    xwjdsh authored and meatballhat committed Oct 3, 2022
    Configuration menu
    Copy the full SHA
    1e30f50 View commit details
    Browse the repository at this point in the history

  50. Add more test cases

    @xwjdsh @meatballhat
    xwjdsh authored and meatballhat committed Oct 3, 2022
    Configuration menu
    Copy the full SHA
    126297a View commit details
    Browse the repository at this point in the history

  51. Fix:(issue_557) Change app help name

    @dearchap @meatballhat
    dearchap authored and meatballhat committed Oct 3, 2022
    Configuration menu
    Copy the full SHA
    4c637d8 View commit details
    Browse the repository at this point in the history

  52. Fix:(issue_557) Make help output consistent between different invocat… 

    …ions
    @dearchap @meatballhat
    dearchap authored and meatballhat committed Oct 3, 2022
    Configuration menu
    Copy the full SHA
    57ff098 View commit details
    Browse the repository at this point in the history

  53. Remove un-needed func

    @dearchap @meatballhat
    dearchap authored and meatballhat committed Oct 3, 2022
    Configuration menu
    Copy the full SHA
    c2ecb44 View commit details
    Browse the repository at this point in the history

  54. Remove un-needed func

    @dearchap @meatballhat
    dearchap authored and meatballhat committed Oct 3, 2022
    Configuration menu
    Copy the full SHA
    8ef92d2 View commit details
    Browse the repository at this point in the history

  55. Remove nonexistent phony targets 

    so that running `make` or `make all` only runs targets that exist.
    @meatballhat
    meatballhat committed Oct 3, 2022
    Configuration menu
    Copy the full SHA
    5db9db6 View commit details
    Browse the repository at this point in the history

  56. Post-porting fixes for v3

    @meatballhat
    meatballhat committed Oct 3, 2022
    Configuration menu
    Copy the full SHA
    f8faf77 View commit details
    Browse the repository at this point in the history

  57. Point docs tests at v3

    @meatballhat
    meatballhat committed Oct 3, 2022
    Configuration menu
    Copy the full SHA
    a851a77 View commit details
    Browse the repository at this point in the history

Commits on Oct 6, 2022

  1. Merge pull request urfave#1510 from urfave/v3-porting 

    Porting to v3
    @dearchap
    dearchap committed Oct 6, 2022
    Configuration menu
    Copy the full SHA
    9166808 View commit details
    Browse the repository at this point in the history

Commits on Oct 8, 2022

  1. Revert "Remove all flag interfaces" 

    This reverts commit 268cb97.
    @dearchap
    dearchap committed Oct 8, 2022
    Configuration menu
    Copy the full SHA
    1a31a6e View commit details
    Browse the repository at this point in the history

  2. Revert changes

    @dearchap
    dearchap committed Oct 8, 2022
    Configuration menu
    Copy the full SHA
    cf41aab View commit details
    Browse the repository at this point in the history

  3. Run v2approve

    @dearchap
    dearchap committed Oct 8, 2022
    Configuration menu
    Copy the full SHA
    662deaa View commit details
    Browse the repository at this point in the history

Commits on Oct 9, 2022

  1. wrap: Avoid trailing whitespace for empty lines

    @abitrolly @meatballhat
    abitrolly authored and meatballhat committed Oct 9, 2022
    Configuration menu
    Copy the full SHA
    a6f5ca6 View commit details
    Browse the repository at this point in the history

  2. Fix test for removed trailing whitespace

    @abitrolly @meatballhat
    abitrolly authored and meatballhat committed Oct 9, 2022
    Configuration menu
    Copy the full SHA
    d3bb381 View commit details
    Browse the repository at this point in the history

  3. wrap: Simplify loop logic 

    Suggested by @julian7
    @abitrolly @meatballhat
    abitrolly authored and meatballhat committed Oct 9, 2022
    Configuration menu
    Copy the full SHA
    05fb755 View commit details
    Browse the repository at this point in the history

  4. Run go fmt

    @abitrolly @meatballhat
    abitrolly authored and meatballhat committed Oct 9, 2022
    Configuration menu
    Copy the full SHA
    e14dca7 View commit details
    Browse the repository at this point in the history

  5. Refactor wrap() and add test for empty line

    @abitrolly @meatballhat
    abitrolly authored and meatballhat committed Oct 9, 2022
    Configuration menu
    Copy the full SHA
    4959a9f View commit details
    Browse the repository at this point in the history

  6. Call FlagStringer in String() method of slice flags 

    The default help template relies on the String() method of Flag
to render the flag. For most flag types, String() indirects through
FlagStringer, so that is the best place to customize flag rendering.

FlagStringer was not called for slice flags because their help output
differs from other flags in two ways: there can be multiple default
values, and the flag name is shown two times to indicate that the flag
can be specified multiple times.

To make multiple values work in the FlagStringer, I simply changed
GetValue() to return all values.

Showing the flag more than once is achieved through a new interface,
DocGenerationSliceFlag, which the FlagStringer uses to decide whether
the flag is a slice flag type.
    @fjl @meatballhat
    fjl authored and meatballhat committed Oct 9, 2022
    Configuration menu
    Copy the full SHA
    82ea9f7 View commit details
    Browse the repository at this point in the history

  7. Ensure "generate" step runs in CI prior to diff check

    @meatballhat
    meatballhat committed Oct 9, 2022
    Configuration menu
    Copy the full SHA
    65c98c8 View commit details
    Browse the repository at this point in the history

  8. Only run generate on go 1.19

    @meatballhat
    meatballhat committed Oct 9, 2022
    Configuration menu
    Copy the full SHA
    c5057d1 View commit details
    Browse the repository at this point in the history

  9. Set destination in GenericFlag apply function 

    The function was missing destination configuration.
    @nkuba @meatballhat
    nkuba authored and meatballhat committed Oct 9, 2022
    Configuration menu
    Copy the full SHA
    01bdec7 View commit details
    Browse the repository at this point in the history

  10. Add unit test for GenericFlag Destination parsing 

    The test checks if Destination provided in GenericFlag is being set as
expected.
    @nkuba @meatballhat
    nkuba authored and meatballhat committed Oct 9, 2022
    Configuration menu
    Copy the full SHA
    b82e628 View commit details
    Browse the repository at this point in the history

  11. Fix:(issue_1505) Fix flag alignment in help

    @dearchap @meatballhat
    dearchap authored and meatballhat committed Oct 9, 2022
    Configuration menu
    Copy the full SHA
    13860a7 View commit details
    Browse the repository at this point in the history

  12. Fix command help subcommand

    @dearchap @meatballhat
    dearchap authored and meatballhat committed Oct 9, 2022
    Configuration menu
    Copy the full SHA
    ae8c511 View commit details
    Browse the repository at this point in the history

  13. Add test case

    @dearchap @meatballhat
    dearchap authored and meatballhat committed Oct 9, 2022
    Configuration menu
    Copy the full SHA
    c86805d View commit details
    Browse the repository at this point in the history

  14. Componentize template

    @dearchap @meatballhat
    dearchap authored and meatballhat committed Oct 9, 2022
    Configuration menu
    Copy the full SHA
    dccd762 View commit details
    Browse the repository at this point in the history

  15. Update template.go 

    Co-authored-by: Anatoli Babenia <anatoli@rainforce.org>
    @dearchap @abitrolly @meatballhat
    2 people authored and meatballhat committed Oct 9, 2022
    Configuration menu
    Copy the full SHA
    a4b7759 View commit details
    Browse the repository at this point in the history

  16. Add test coverage for Command.VisibleCommands()

    @dearchap @meatballhat
    dearchap authored and meatballhat committed Oct 9, 2022
    Configuration menu
    Copy the full SHA
    9a94619 View commit details
    Browse the repository at this point in the history

  17. Remove extra 3 spaces in last line

    @dearchap @meatballhat
    dearchap authored and meatballhat committed Oct 9, 2022
    Configuration menu
    Copy the full SHA
    ea28930 View commit details
    Browse the repository at this point in the history

  18. Fix:(issue_1500). Fix slice flag value duplication issue

    @dearchap @meatballhat
    dearchap authored and meatballhat committed Oct 9, 2022
    Configuration menu
    Copy the full SHA
    924ebda View commit details
    Browse the repository at this point in the history

  19. Fix failed test

    @dearchap @meatballhat
    dearchap authored and meatballhat committed Oct 9, 2022
    Configuration menu
    Copy the full SHA
    fcb0bce View commit details
    Browse the repository at this point in the history

  20. Merge pull request urfave#1517 from dearchap/revert_remove_all_flag_i… 

    …nterfaces
    @dearchap
    dearchap committed Oct 9, 2022
    Configuration menu
    Copy the full SHA
    83ea416 View commit details
    Browse the repository at this point in the history

  21. Merge remote-tracking branch 'origin/v3-dev-main' into v3-porting

    @meatballhat
    meatballhat committed Oct 9, 2022
    Configuration menu
    Copy the full SHA
    64facdb View commit details
    Browse the repository at this point in the history

  22. Remove duplicate DocGenerationFlag interface 

    introduced via merge
    @meatballhat
    meatballhat committed Oct 9, 2022
    Configuration menu
    Copy the full SHA
    9621675 View commit details
    Browse the repository at this point in the history

Commits on Oct 10, 2022

  1. Backfill drop of generated GetDefaultText method

    @meatballhat
    meatballhat committed Oct 10, 2022
    Configuration menu
    Copy the full SHA
    6404f1d View commit details
    Browse the repository at this point in the history

Commits on Oct 13, 2022

  1. Build and run urfave-cli-genflags via its Makefile 

    so that `go.mod` files don't get all confused
    @meatballhat
    meatballhat committed Oct 13, 2022
    Configuration menu
    Copy the full SHA
    b458207 View commit details
    Browse the repository at this point in the history

  2. Use existing goimports installation if available

    @meatballhat
    meatballhat committed Oct 13, 2022
    Configuration menu
    Copy the full SHA
    75aabac View commit details
    Browse the repository at this point in the history

  3. Un-regress from v3 porting losses

    @meatballhat
    meatballhat committed Oct 13, 2022
    Configuration menu
    Copy the full SHA
    85ff0c5 View commit details
    Browse the repository at this point in the history

Commits on Oct 16, 2022

  1. Merge pull request urfave#1525 from urfave/v3-porting 

    Porting changes from `main` to `v3-dev-main` (circa 2022-10-09)
    @meatballhat
    meatballhat committed Oct 16, 2022
    Configuration menu
    Copy the full SHA
    25897ce View commit details
    Browse the repository at this point in the history

Commits on Nov 7, 2022

  1. Merge commit 'c8147a4' into v3-porting

    @meatballhat
    meatballhat committed Nov 7, 2022
    Configuration menu
    Copy the full SHA
    9aa0dd7 View commit details
    Browse the repository at this point in the history

  2. Merge commit 'e3ee4fb' into v3-porting

    @meatballhat
    meatballhat committed Nov 7, 2022
    Configuration menu
    Copy the full SHA
    874d06d View commit details
    Browse the repository at this point in the history

  3. Merge commit 'ade5edb' into v3-porting

    @meatballhat
    meatballhat committed Nov 7, 2022
    Configuration menu
    Copy the full SHA
    16c0635 View commit details
    Browse the repository at this point in the history

  4. Merge commit 'af3b50c' into v3-porting

    @meatballhat
    meatballhat committed Nov 7, 2022
    Configuration menu
    Copy the full SHA
    fd3354f View commit details
    Browse the repository at this point in the history

  5. Merge commit '6ff3e8e' into v3-porting

    @meatballhat
    meatballhat committed Nov 7, 2022
    Configuration menu
    Copy the full SHA
    3c66d6d View commit details
    Browse the repository at this point in the history

  6. Merge commit '234972e' into v3-porting

    @meatballhat
    meatballhat committed Nov 7, 2022
    Configuration menu
    Copy the full SHA
    63b730e View commit details
    Browse the repository at this point in the history

  7. Merge commit '3a1b6de' into v3-porting

    @meatballhat
    meatballhat committed Nov 7, 2022
    Configuration menu
    Copy the full SHA
    ba1c00e View commit details
    Browse the repository at this point in the history

  8. Merge commit '87dedb6' into v3-porting

    @meatballhat
    meatballhat committed Nov 7, 2022
    Configuration menu
    Copy the full SHA
    f68da12 View commit details
    Browse the repository at this point in the history

  9. Merge commit 'dac1c40' into v3-porting

    @meatballhat
    meatballhat committed Nov 7, 2022
    Configuration menu
    Copy the full SHA
    140c96c View commit details
    Browse the repository at this point in the history

  10. Merge commit 'c6616c3' into v3-porting

    @meatballhat
    meatballhat committed Nov 7, 2022
    Configuration menu
    Copy the full SHA
    8c34fbc View commit details
    Browse the repository at this point in the history

  11. Merge commit '7357e10' into v3-porting

    @meatballhat
    meatballhat committed Nov 7, 2022
    Configuration menu
    Copy the full SHA
    504ec56 View commit details
    Browse the repository at this point in the history

  12. Merge commit '7b28ca5' into v3-porting

    @meatballhat
    meatballhat committed Nov 7, 2022
    Configuration menu
    Copy the full SHA
    4e3a327 View commit details
    Browse the repository at this point in the history

  13. Merge commit 'b4df361' into v3-porting

    @meatballhat
    meatballhat committed Nov 7, 2022
    Configuration menu
    Copy the full SHA
    ff6f4b4 View commit details
    Browse the repository at this point in the history

  14. Merge commit 'f394c37' into v3-porting

    @meatballhat
    meatballhat committed Nov 7, 2022
    Configuration menu
    Copy the full SHA
    38546ca View commit details
    Browse the repository at this point in the history

  15. Merge commit '77a5fef' into v3-porting

    @meatballhat
    meatballhat committed Nov 7, 2022
    Configuration menu
    Copy the full SHA
    ade08d5 View commit details
    Browse the repository at this point in the history

  16. Merge commit '8b23e7b' into v3-porting

    @meatballhat
    meatballhat committed Nov 7, 2022
    Configuration menu
    Copy the full SHA
    a9bf2e7 View commit details
    Browse the repository at this point in the history

  17. Merge commit 'b98c059' into v3-porting

    @meatballhat
    meatballhat committed Nov 7, 2022
    Configuration menu
    Copy the full SHA
    c19cd38 View commit details
    Browse the repository at this point in the history

  18. Merge commit 'f664246' into v3-porting

    @meatballhat
    meatballhat committed Nov 7, 2022
    Configuration menu
    Copy the full SHA
    5dcfcce View commit details
    Browse the repository at this point in the history

  19. Merge commit '514a114' into v3-porting

    @meatballhat
    meatballhat committed Nov 7, 2022
    Configuration menu
    Copy the full SHA
    dc0ad27 View commit details
    Browse the repository at this point in the history

  20. Merge commit '254c38e' into v3-porting

    @meatballhat
    meatballhat committed Nov 7, 2022
    Configuration menu
    Copy the full SHA
    037f2e0 View commit details
    Browse the repository at this point in the history

  21. Merge commit 'ca9df40' into v3-porting

    @meatballhat
    meatballhat committed Nov 7, 2022
    Configuration menu
    Copy the full SHA
    a210601 View commit details
    Browse the repository at this point in the history

  22. Merge commit 'f451dea' into v3-porting

    @meatballhat
    meatballhat committed Nov 7, 2022
    Configuration menu
    Copy the full SHA
    86c8e26 View commit details
    Browse the repository at this point in the history

  23. Merge commit '31c5137' into v3-porting

    @meatballhat
    meatballhat committed Nov 7, 2022
    Configuration menu
    Copy the full SHA
    5a4235b View commit details
    Browse the repository at this point in the history

  24. Merge commit 'b1b1b27' into v3-porting

    @meatballhat
    meatballhat committed Nov 7, 2022
    Configuration menu
    Copy the full SHA
    e903170 View commit details
    Browse the repository at this point in the history

  25. Merge commit '6ccecf2' into v3-porting

    @meatballhat
    meatballhat committed Nov 7, 2022
    Configuration menu
    Copy the full SHA
    c6217c3 View commit details
    Browse the repository at this point in the history

  26. Merge commit 'd62ac9c' into v3-porting

    @meatballhat
    meatballhat committed Nov 7, 2022
    Configuration menu
    Copy the full SHA
    edd0171 View commit details
    Browse the repository at this point in the history

  27. Merge commit '6124f3a' into v3-porting

    @meatballhat
    meatballhat committed Nov 7, 2022
    Configuration menu
    Copy the full SHA
    94aa8fa View commit details
    Browse the repository at this point in the history

  28. Merge commit '8dba5c3' into v3-porting

    @meatballhat
    meatballhat committed Nov 7, 2022
    Configuration menu
    Copy the full SHA
    b74b095 View commit details
    Browse the repository at this point in the history

  29. Merge commit '375e5df' into v3-porting

    @meatballhat
    meatballhat committed Nov 7, 2022
    Configuration menu
    Copy the full SHA
    2472253 View commit details
    Browse the repository at this point in the history

  30. Merge commit '69f4122' into v3-porting

    @meatballhat
    meatballhat committed Nov 7, 2022
    Configuration menu
    Copy the full SHA
    9916a64 View commit details
    Browse the repository at this point in the history

  31. Merge commit '9120e06' into v3-porting

    @meatballhat
    meatballhat committed Nov 7, 2022
    Configuration menu
    Copy the full SHA
    3c86c6d View commit details
    Browse the repository at this point in the history

  32. Merge commit '880a802' into v3-porting

    @meatballhat
    meatballhat committed Nov 7, 2022
    Configuration menu
    Copy the full SHA
    66586eb View commit details
    Browse the repository at this point in the history

  33. Merge commit '9f465af' into v3-porting

    @meatballhat
    meatballhat committed Nov 7, 2022
    Configuration menu
    Copy the full SHA
    6ff66e0 View commit details
    Browse the repository at this point in the history

  34. Merge commit 'a81e201' into v3-porting

    @meatballhat
    meatballhat committed Nov 7, 2022
    Configuration menu
    Copy the full SHA
    0a0546f View commit details
    Browse the repository at this point in the history

  35. Merge commit 'de83493' into v3-porting

    @meatballhat
    meatballhat committed Nov 7, 2022
    Configuration menu
    Copy the full SHA
    0de6633 View commit details
    Browse the repository at this point in the history

  36. Merge commit '6491dde' into v3-porting

    @meatballhat
    meatballhat committed Nov 7, 2022
    Configuration menu
    Copy the full SHA
    cc9361c View commit details
    Browse the repository at this point in the history

  37. Merge commit '8335f54' into v3-porting

    @meatballhat
    meatballhat committed Nov 7, 2022
    Configuration menu
    Copy the full SHA
    f28f38d View commit details
    Browse the repository at this point in the history

  38. Merge commit 'fe6f62b' into v3-porting

    @meatballhat
    meatballhat committed Nov 7, 2022
    Configuration menu
    Copy the full SHA
    110e97b View commit details
    Browse the repository at this point in the history

  39. Merge commit '2da0324' into v3-porting

    @meatballhat
    meatballhat committed Nov 7, 2022
    Configuration menu
    Copy the full SHA
    1ed843e View commit details
    Browse the repository at this point in the history

  40. Merge commit 'a27294d' into v3-porting

    @meatballhat
    meatballhat committed Nov 7, 2022
    Configuration menu
    Copy the full SHA
    0f45f18 View commit details
    Browse the repository at this point in the history

  41. Merge commit '3c5c3a4' into v3-porting

    @meatballhat
    meatballhat committed Nov 7, 2022
    Configuration menu
    Copy the full SHA
    af8fe35 View commit details
    Browse the repository at this point in the history

  42. Merge commit 'b68db8d' into v3-porting

    @meatballhat
    meatballhat committed Nov 7, 2022
    Configuration menu
    Copy the full SHA
    0420682 View commit details
    Browse the repository at this point in the history

  43. Merge commit '8f469ab' into v3-porting

    @meatballhat
    meatballhat committed Nov 7, 2022
    Configuration menu
    Copy the full SHA
    d23a7e4 View commit details
    Browse the repository at this point in the history

  44. Merge commit '2a4809f' into v3-porting

    @meatballhat
    meatballhat committed Nov 7, 2022
    Configuration menu
    Copy the full SHA
    fb50ebc View commit details
    Browse the repository at this point in the history

  45. Merge commit 'f64acc4' into v3-porting

    @meatballhat
    meatballhat committed Nov 7, 2022
    Configuration menu
    Copy the full SHA
    a1f9917 View commit details
    Browse the repository at this point in the history

  46. Merge commit 'f37b9d9' into v3-porting

    @meatballhat
    meatballhat committed Nov 7, 2022
    Configuration menu
    Copy the full SHA
    f94fffd View commit details
    Browse the repository at this point in the history

  47. Merge commit '89e331f' into v3-porting

    @meatballhat
    meatballhat committed Nov 7, 2022
    Configuration menu
    Copy the full SHA
    8bcc404 View commit details
    Browse the repository at this point in the history

  48. Merge commit '0d0d329' into v3-porting

    @meatballhat
    meatballhat committed Nov 7, 2022
    Configuration menu
    Copy the full SHA
    581cfd1 View commit details
    Browse the repository at this point in the history

  49. Merge commit 'adcd0c9' into v3-porting

    @meatballhat
    meatballhat committed Nov 7, 2022
    Configuration menu
    Copy the full SHA
    8530ea2 View commit details
    Browse the repository at this point in the history

  50. Merge commit '39b1245' into v3-porting

    @meatballhat
    meatballhat committed Nov 7, 2022
    Configuration menu
    Copy the full SHA
    4ac1d33 View commit details
    Browse the repository at this point in the history

  51. Merge commit '5ac0710' into v3-porting

    @meatballhat
    meatballhat committed Nov 7, 2022
    Configuration menu
    Copy the full SHA
    b0e8160 View commit details
    Browse the repository at this point in the history

  52. Merge commit 'cf49ddb' into v3-porting

    @meatballhat
    meatballhat committed Nov 7, 2022
    Configuration menu
    Copy the full SHA
    1564c86 View commit details
    Browse the repository at this point in the history

  53. Merge commit 'd1ac284' into v3-porting

    @meatballhat
    meatballhat committed Nov 7, 2022
    Configuration menu
    Copy the full SHA
    1643a78 View commit details
    Browse the repository at this point in the history

  54. Merge commit '8ea10b8' into v3-porting

    @meatballhat
    meatballhat committed Nov 7, 2022
    Configuration menu
    Copy the full SHA
    2a68aa0 View commit details
    Browse the repository at this point in the history

  55. Merge commit '7563894' into v3-porting

    @meatballhat
    meatballhat committed Nov 7, 2022
    Configuration menu
    Copy the full SHA
    d3a4181 View commit details
    Browse the repository at this point in the history

  56. Merge commit '82bdf5f' into v3-porting

    @meatballhat
    meatballhat committed Nov 7, 2022
    Configuration menu
    Copy the full SHA
    da23da7 View commit details
    Browse the repository at this point in the history

  57. Merge commit '63cb372' into v3-porting

    @meatballhat
    meatballhat committed Nov 7, 2022
    Configuration menu
    Copy the full SHA
    5e5df7c View commit details
    Browse the repository at this point in the history

  58. Merge commit 'c344b46' into v3-porting

    @meatballhat
    meatballhat committed Nov 7, 2022
    Configuration menu
    Copy the full SHA
    84af977 View commit details
    Browse the repository at this point in the history

  59. Merge commit 'ae8d932' into v3-porting

    @meatballhat
    meatballhat committed Nov 7, 2022
    Configuration menu
    Copy the full SHA
    494ff26 View commit details
    Browse the repository at this point in the history

  60. Merge commit 'c3fccc0' into v3-porting

    @meatballhat
    meatballhat committed Nov 7, 2022
    Configuration menu
    Copy the full SHA
    d80f366 View commit details
    Browse the repository at this point in the history

  61. Merge commit 'd0aeb4d' into v3-porting

    @meatballhat
    meatballhat committed Nov 7, 2022
    Configuration menu
    Copy the full SHA
    c6318ce View commit details
    Browse the repository at this point in the history

  62. Merge commit 'e194a18' into v3-porting

    @meatballhat
    meatballhat committed Nov 7, 2022
    Configuration menu
    Copy the full SHA
    3d52a48 View commit details
    Browse the repository at this point in the history

  63. Merge commit '190e5b6' into v3-porting

    @meatballhat
    meatballhat committed Nov 7, 2022
    Configuration menu
    Copy the full SHA
    8b891ea View commit details
    Browse the repository at this point in the history

  64. Merge commit '46043dd' into v3-porting

    @meatballhat
    meatballhat committed Nov 7, 2022
    Configuration menu
    Copy the full SHA
    75f2d1a View commit details
    Browse the repository at this point in the history

Commits on Nov 8, 2022

  1. Adjust expectations around categorized flags

    @meatballhat
    meatballhat committed Nov 8, 2022
    Configuration menu
    Copy the full SHA
    d294a88 View commit details
    Browse the repository at this point in the history

  2. Leave imports to goimports

    @meatballhat
    meatballhat committed Nov 8, 2022
    Configuration menu
    Copy the full SHA
    5e86a2c View commit details
    Browse the repository at this point in the history

  3. More porting fixes and un-lost changes

    @meatballhat
    meatballhat committed Nov 8, 2022
    Configuration menu
    Copy the full SHA
    a5ec63b View commit details
    Browse the repository at this point in the history

  4. Merge pull request urfave#1569 from urfave/v3-porting 

    Porting `main` to `v3-dev-main` circa 2022-11-06
    @meatballhat
    meatballhat committed Nov 8, 2022
    Configuration menu
    Copy the full SHA
    c296830 View commit details
    Browse the repository at this point in the history

  5. Update branch explanations and semver-ish automation 

    given move to main as v3
    @meatballhat
    meatballhat committed Nov 8, 2022
    Configuration menu
    Copy the full SHA
    cbad251 View commit details
    Browse the repository at this point in the history

  6. Merge pull request urfave#1572 from urfave/explain-branches 

    Update branch explanations and semver-ish automation
    @meatballhat
    meatballhat committed Nov 8, 2022
    Configuration menu
    Copy the full SHA
    766786f View commit details
    Browse the repository at this point in the history

  7. Update GitHub Actions events for v3 mode

    @meatballhat
    meatballhat committed Nov 8, 2022
    Configuration menu
    Copy the full SHA
    5133e28 View commit details
    Browse the repository at this point in the history

  8. Remove local altsrc and references 

    in favor of separate repo at https://github.com/urfave/cli-altsrc
    @meatballhat
    meatballhat committed Nov 8, 2022
    Configuration menu
    Copy the full SHA
    9361cba View commit details
    Browse the repository at this point in the history

  9. Merge pull request urfave#1575 from urfave/gha-v3-mode 

    Update GitHub Actions events for v3 mode
    @meatballhat
    meatballhat committed Nov 8, 2022
    Configuration menu
    Copy the full SHA
    dbdd5cb View commit details
    Browse the repository at this point in the history

  10. Merge branch 'main' into extern-altsrc

    @meatballhat
    meatballhat committed Nov 8, 2022
    Configuration menu
    Copy the full SHA
    12f4cba View commit details
    Browse the repository at this point in the history

Commits on Nov 9, 2022

  1. Merge pull request urfave#1576 from urfave/extern-altsrc 

    Remove local altsrc and references
    @meatballhat
    meatballhat committed Nov 9, 2022
    Configuration menu
    Copy the full SHA
    02bba4b View commit details
    Browse the repository at this point in the history

  2. Remove App.Compiled 

    Closes urfave#753
    @meatballhat
    meatballhat committed Nov 9, 2022
    Configuration menu
    Copy the full SHA
    a05e4d0 View commit details
    Browse the repository at this point in the history

  3. Fix urfave#1570

    @remiposo
    remiposo committed Nov 9, 2022
    Configuration menu
    Copy the full SHA
    c72542b View commit details
    Browse the repository at this point in the history

Commits on Nov 10, 2022

  1. Merge pull request urfave#1579 from urfave/drop-compiled 

    Remove App.Compiled
    @meatballhat
    meatballhat committed Nov 10, 2022
    Configuration menu
    Copy the full SHA
    689dfd6 View commit details
    Browse the repository at this point in the history

Commits on Nov 11, 2022

  1. Allow disabling SliceFlag separator altogether

    @feedmeapples
    feedmeapples committed Nov 11, 2022
    Configuration menu
    Copy the full SHA
    508efc3 View commit details
    Browse the repository at this point in the history

  2. replace test hardcode with defaultSliceFlagSeparator

    @feedmeapples
    feedmeapples committed Nov 11, 2022
    Configuration menu
    Copy the full SHA
    d48e897 View commit details
    Browse the repository at this point in the history

  3. Fix urfave#1570: add testcase

    @remiposo
    remiposo committed Nov 11, 2022
    Configuration menu
    Copy the full SHA
    53a6baf View commit details
    Browse the repository at this point in the history

  4. Merge branch 'main' into remiposo/issue_1570

    @remiposo
    remiposo committed Nov 11, 2022
    Configuration menu
    Copy the full SHA
    6185f5c View commit details
    Browse the repository at this point in the history

  5. godoc

    @feedmeapples
    feedmeapples committed Nov 11, 2022
    Configuration menu
    Copy the full SHA
    e3f2cc6 View commit details
    Browse the repository at this point in the history

  6. Merge pull request urfave#1581 from remiposo/remiposo/issue_1570 

    Fix: Nested help command has a incorrect HelpName
    @dearchap
    dearchap committed Nov 11, 2022
    Configuration menu
    Copy the full SHA
    d219eb1 View commit details
    Browse the repository at this point in the history

Commits on Nov 12, 2022

  1. Merge pull request urfave#1582 from feedmeapples/allow-disabling-slic… 

    …e-separator

Allow disabling slice flag separator
    @dearchap
    dearchap committed Nov 12, 2022
    Configuration menu
    Copy the full SHA
    eb6cc14 View commit details
    Browse the repository at this point in the history

Commits on Nov 16, 2022

  1. Update godoc v3 spacing

    @feedmeapples
    feedmeapples committed Nov 16, 2022
    Configuration menu
    Copy the full SHA
    babf3b3 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into v3-godoc

    @feedmeapples
    feedmeapples committed Nov 16, 2022
    Configuration menu
    Copy the full SHA
    904d954 View commit details
    Browse the repository at this point in the history

Commits on Nov 18, 2022

  1. Merge pull request urfave#1589 from feedmeapples/v3-godoc 

    Fix spacing in godoc
    @dearchap
    dearchap committed Nov 18, 2022
    Configuration menu
    Copy the full SHA
    268bea7 View commit details
    Browse the repository at this point in the history

Commits on Nov 26, 2022

  1. First cut at using generics for base flag types

    @dearchap
    dearchap committed Nov 26, 2022
    Configuration menu
    Copy the full SHA
    1dd43a7 View commit details
    Browse the repository at this point in the history

  2. Add generics

    @dearchap
    dearchap committed Nov 26, 2022
    Configuration menu
    Copy the full SHA
    2862b2f View commit details
    Browse the repository at this point in the history

  3. Stage

    @dearchap
    dearchap committed Nov 26, 2022
    Configuration menu
    Copy the full SHA
    74d5175 View commit details
    Browse the repository at this point in the history

  4. Rebase

    @dearchap
    dearchap committed Nov 26, 2022
    Configuration menu
    Copy the full SHA
    876fa0f View commit details
    Browse the repository at this point in the history

  5. Add all flags

    @dearchap
    dearchap committed Nov 26, 2022
    Configuration menu
    Copy the full SHA
    3566f6f View commit details
    Browse the repository at this point in the history

  6. Add FlagConfig

    @dearchap
    dearchap committed Nov 26, 2022
    Configuration menu
    Copy the full SHA
    328f330 View commit details
    Browse the repository at this point in the history

  7. Rebase

    @dearchap
    dearchap committed Nov 26, 2022
    Configuration menu
    Copy the full SHA
    8182560 View commit details
    Browse the repository at this point in the history

  8. Fix all tests

    @dearchap
    dearchap committed Nov 26, 2022
    Configuration menu
    Copy the full SHA
    5398324 View commit details
    Browse the repository at this point in the history

  9. Remove debug log

    @dearchap
    dearchap committed Nov 26, 2022
    Configuration menu
    Copy the full SHA
    736f770 View commit details
    Browse the repository at this point in the history

  10. Fix go1.18 crash

    @dearchap
    dearchap committed Nov 26, 2022
    Configuration menu
    Copy the full SHA
    db86d8a View commit details
    Browse the repository at this point in the history

  11. Run make v3approve

    @dearchap
    dearchap committed Nov 26, 2022
    Configuration menu
    Copy the full SHA
    3936aba View commit details
    Browse the repository at this point in the history

  12. Fix doc tests

    @dearchap
    dearchap committed Nov 26, 2022
    Configuration menu
    Copy the full SHA
    420e001 View commit details
    Browse the repository at this point in the history

  13. Changes from code review

    @dearchap
    dearchap committed Nov 26, 2022
    Configuration menu
    Copy the full SHA
    0e6ed53 View commit details
    Browse the repository at this point in the history

  14. Update v3approve

    @dearchap
    dearchap committed Nov 26, 2022
    Configuration menu
    Copy the full SHA
    0833b92 View commit details
    Browse the repository at this point in the history

  15. Add slice flag support

    @dearchap
    dearchap committed Nov 26, 2022
    Configuration menu
    Copy the full SHA
    2086bd7 View commit details
    Browse the repository at this point in the history

  16. Fix go1.18 crash

    @dearchap
    dearchap committed Nov 26, 2022
    Configuration menu
    Copy the full SHA
    b24a04f View commit details
    Browse the repository at this point in the history

  17. Optimize string for slice base

    @dearchap
    dearchap committed Nov 26, 2022
    Configuration menu
    Copy the full SHA
    c3f7459 View commit details
    Browse the repository at this point in the history

  18. Add support for timestamp flag generics

    @dearchap
    dearchap committed Nov 26, 2022
    Configuration menu
    Copy the full SHA
    397a9df View commit details
    Browse the repository at this point in the history

  19. Add config for flags

    @dearchap
    dearchap committed Nov 26, 2022
    Configuration menu
    Copy the full SHA
    8d49a02 View commit details
    Browse the repository at this point in the history

  20. Remove generic and path flags

    @dearchap
    dearchap committed Nov 26, 2022
    Configuration menu
    Copy the full SHA
    2d86e0d View commit details
    Browse the repository at this point in the history

  21. Change flag.Value to Value

    @dearchap
    dearchap committed Nov 26, 2022
    Configuration menu
    Copy the full SHA
    975e8c0 View commit details
    Browse the repository at this point in the history

  22. Add comments

    @dearchap
    dearchap committed Nov 26, 2022
    Configuration menu
    Copy the full SHA
    d9780ea View commit details
    Browse the repository at this point in the history

  23. Add doc updates

    @dearchap
    dearchap committed Nov 26, 2022
    Configuration menu
    Copy the full SHA
    66f601a View commit details
    Browse the repository at this point in the history

  24. Add doc updates

    @dearchap
    dearchap committed Nov 26, 2022
    Configuration menu
    Copy the full SHA
    a84e9c5 View commit details
    Browse the repository at this point in the history

  25. Remove getter

    @dearchap
    dearchap committed Nov 26, 2022
    Configuration menu
    Copy the full SHA
    a192703 View commit details
    Browse the repository at this point in the history

  26. Update flag_slice_impl.go 

    Co-authored-by: Dan Buch <dan@meatballhat.com>
    @dearchap @meatballhat
    dearchap and meatballhat committed Nov 26, 2022
    Configuration menu
    Copy the full SHA
    d2185f2 View commit details
    Browse the repository at this point in the history

  27. Update flag_slice_impl.go 

    Co-authored-by: Dan Buch <dan@meatballhat.com>
    @dearchap @meatballhat
    dearchap and meatballhat committed Nov 26, 2022
    Configuration menu
    Copy the full SHA
    8483ecb View commit details
    Browse the repository at this point in the history

  28. Update flag_slice_impl.go 

    Co-authored-by: Dan Buch <dan@meatballhat.com>
    @dearchap @meatballhat
    dearchap and meatballhat committed Nov 26, 2022
    Configuration menu
    Copy the full SHA
    9282d69 View commit details
    Browse the repository at this point in the history

  29. Update flag_slice_impl.go 

    Co-authored-by: Dan Buch <dan@meatballhat.com>
    @dearchap @meatballhat
    dearchap and meatballhat committed Nov 26, 2022
    Configuration menu
    Copy the full SHA
    ba96f19 View commit details
    Browse the repository at this point in the history

  30. Update flag_uint.go 

    Co-authored-by: Dan Buch <dan@meatballhat.com>
    @dearchap @meatballhat
    dearchap and meatballhat committed Nov 26, 2022
    Configuration menu
    Copy the full SHA
    ddede27 View commit details
    Browse the repository at this point in the history

  31. Update flag_uint64.go 

    Co-authored-by: Dan Buch <dan@meatballhat.com>
    @dearchap @meatballhat
    dearchap and meatballhat committed Nov 26, 2022
    Configuration menu
    Copy the full SHA
    b414bd1 View commit details
    Browse the repository at this point in the history

  32. Changes from code review

    @dearchap
    dearchap committed Nov 26, 2022
    Configuration menu
    Copy the full SHA
    e2e3aa0 View commit details
    Browse the repository at this point in the history

  33. Merge pull request urfave#1512 from dearchap/use_generics 

    First cut at using generics for base flag types
    @dearchap
    dearchap committed Nov 26, 2022
    Configuration menu
    Copy the full SHA
    aef9126 View commit details
    Browse the repository at this point in the history

  34. Make *cli.Context implement context.Context by renaming Value

    @marwan-at-work
    marwan-at-work committed Nov 26, 2022
    Configuration menu
    Copy the full SHA
    6d5d5ef View commit details
    Browse the repository at this point in the history

  35. Run make generate

    @marwan-at-work
    marwan-at-work committed Nov 26, 2022
    Configuration menu
    Copy the full SHA
    dbeb354 View commit details
    Browse the repository at this point in the history

Commits on Nov 27, 2022

  1. CI fix

    @marwan-at-work
    marwan-at-work committed Nov 27, 2022
    Configuration menu
    Copy the full SHA
    4cc0645 View commit details
    Browse the repository at this point in the history