Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update many v1 things #1654

Merged
merged 4 commits into from Jan 22, 2023
Merged

Update many v1 things #1654

merged 4 commits into from Jan 22, 2023

Conversation

meatballhat
Copy link
Member

What type of PR is this?

  • cleanup

What this PR does / why we need it:

including:

  • testing on windows-latest in CI
  • updating license year
  • updating badges in README
  • removing references to outdated v2 docs
  • removing references to GOPATH
  • removing appveyer config
  • introducing stretchr/testify for comparison assertions
  • replacing usage of ioutil
  • updating all dependencies
  • removing outdated version-specific test files

including:
- testing on `windows-latest` in CI
- updating license year
- updating badges in README
- removing references to outdated v2 docs
- removing references to `GOPATH`
- removing appveyer config
- introducing stretchr/testify for comparison assertions
- replacing usage of `ioutil`
- updating all dependencies
- removing outdated version-specific test files
@meatballhat meatballhat added this to the Release 1.22.x milestone Jan 22, 2023
@meatballhat meatballhat requested a review from a team as a code owner January 22, 2023 19:38
@@ -163,6 +165,11 @@ func GfmrunActionFunc(c *cli.Context) error {
}

func TocActionFunc(c *cli.Context) error {
if runtime.GOOS == "windows" {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you want to move this to build_windows.go ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was trying to avoid adding a separate file 🤷🏼

@meatballhat meatballhat merged commit 49f9838 into v1-maint Jan 22, 2023
@meatballhat meatballhat deleted the v1-ci-updates branch January 22, 2023 22:21
mudler pushed a commit to kairos-io/provider-kairos that referenced this pull request Jan 25, 2023
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [github.com/urfave/cli](https://togithub.com/urfave/cli) | require |
patch | `v1.22.11` -> `v1.22.12` |

---

### Release Notes

<details>
<summary>urfave/cli</summary>

### [`v1.22.12`](https://togithub.com/urfave/cli/releases/tag/v1.22.12)

[Compare
Source](https://togithub.com/urfave/cli/compare/v1.22.11...v1.22.12)

#### What's Changed

- Update many v1 things by
[@&#8203;meatballhat](https://togithub.com/meatballhat) in
[urfave/cli#1654

**Full Changelog**:
urfave/cli@v1.22.11...v1.22.12

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://app.renovatebot.com/dashboard#github/kairos-io/provider-kairos).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC4xMDguNCIsInVwZGF0ZWRJblZlciI6IjM0LjEwOC40In0=-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants