Show non categorized flags with categorized on help #1673
Merged
+85
−45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skelouse
changed the title
dearchap
reviewed
Jan 29, 2023
|
I think the main concern is whether empty string should be counted as a category. I am ok with either but it would be good if some stakeholders can chime in on this cc @urfave/cli |
dearchap
approved these changes
Jan 29, 2023
|
v2.24.2? @dearchap |
mudler
referenced
this pull request
in kairos-io/provider-kairos
Jan 30, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [github.com/urfave/cli/v2](https://togithub.com/urfave/cli) | require | patch | `v2.24.1` -> `v2.24.2` | --- ### Release Notes <details> <summary>urfave/cli</summary> ### [`v2.24.2`](https://togithub.com/urfave/cli/releases/tag/v2.24.2) [Compare Source](https://togithub.com/urfave/cli/compare/v2.24.1...v2.24.2) #### What's Changed - Update README badges for v2 by [@​meatballhat](https://togithub.com/meatballhat) in [https://github.com/urfave/cli/pull/1664](https://togithub.com/urfave/cli/pull/1664) - Target two most recent Go versions in v2 by [@​meatballhat](https://togithub.com/meatballhat) in [https://github.com/urfave/cli/pull/1666](https://togithub.com/urfave/cli/pull/1666) - flag: remove dependencies on shared variables by [@​zllovesuki](https://togithub.com/zllovesuki) in [https://github.com/urfave/cli/pull/1671](https://togithub.com/urfave/cli/pull/1671) - Show non categorized flags with categorized on help by [@​skelouse](https://togithub.com/skelouse) in [https://github.com/urfave/cli/pull/1673](https://togithub.com/urfave/cli/pull/1673) #### New Contributors - [@​zllovesuki](https://togithub.com/zllovesuki) made their first contribution in [https://github.com/urfave/cli/pull/1671](https://togithub.com/urfave/cli/pull/1671) **Full Changelog**: urfave/cli@v2.24.1...v2.24.2 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/kairos-io/provider-kairos). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC4xMDguNCIsInVwZGF0ZWRJblZlciI6IjM0LjExNi4xIn0=--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
|
@dearchap Apologies for the necroposting, but it seems that Or will it be better if I will do that? /cc @jetexe |
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
Reverting the removal of visible flags from help if their sibling flags have categories defined.
Example:
Which issue(s) this PR fixes:
fixes #1672
Release Notes