Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run go mod tidy #1907

Merged
merged 3 commits into from May 5, 2024
Merged

Run go mod tidy #1907

merged 3 commits into from May 5, 2024

Conversation

meatballhat
Copy link
Member

@meatballhat meatballhat commented May 5, 2024

What type of PR is this?

  • cleanup

What this PR does / why we need it:

Remove unused entries from go.mod and go.sum

Which issue(s) this PR fixes:

#1908

@meatballhat meatballhat added the area/v3 relates to / is being considered for v3 label May 5, 2024
@meatballhat meatballhat requested a review from a team as a code owner May 5, 2024 01:45
Copy link
Contributor

@Juneezee Juneezee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need github.com/urfave/cli-altsrc/v3 indirect dependency for

"github.com/urfave/cli-altsrc/v3"

Otherwise make gfmrun fails

@meatballhat
Copy link
Member Author

We need github.com/urfave/cli-altsrc/v3 indirect dependency for

"github.com/urfave/cli-altsrc/v3"

Otherwise make gfmrun fails

Yep! I'd like to treat this as a bug/cleanup at this point. Using go mod ... commands at the top level should "just work", imho. Issue captured after the fact: #1908 WDYT?

Copy link
Contributor

@Juneezee Juneezee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@meatballhat meatballhat merged commit 817dcbc into main May 5, 2024
15 checks passed
@meatballhat meatballhat deleted the tidy-go-mod branch May 5, 2024 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/v3 relates to / is being considered for v3
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants