Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix ExitErrHandler not used with subcommands #761

Closed
wants to merge 1 commit into from

Conversation

travisperson
Copy link

Errors returned by subcommands no longer bypass the toplevel ExitErrHandler

Fixes #736

@jkanywhere
Copy link

AppVeyer build is failing because go vet

python runtests vet
45# github.com/urfave/cli
46.\command_test.go:328:3: value declared but not used
47vet: typecheck failures
48runtests: go vet ./...
...

which is odd because value defined on line 328 is used on line 340, and this diff doesn't alter that part of the file.

@phinnaeus
Copy link
Contributor

phinnaeus commented Aug 20, 2018

@jkanywhere It's failing on master, without these changes at all. I created #765 to fix that.

Edit: disregard, I'm an idiot. I see you already fixed in #763

Errors returned by subcommands no longer bypass the toplevel ExitErrHandler

Fixes urfave#736
@HenrikPoulsen
Copy link

This is still an issue. What is preventing us from merging this in at this point?

@coilysiren
Copy link
Member

coilysiren commented Aug 23, 2019

A change identical to this one was merged in this PR => #856

@coilysiren coilysiren closed this Aug 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Errors returned by subcommands are ignored by ExitErrHandler
5 participants