Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Required flags #819

Merged
merged 63 commits into from
Aug 2, 2019
Merged

Required flags #819

merged 63 commits into from
Aug 2, 2019

Commits on Dec 2, 2014

  1. Implement required flags

    @riot-builder
    Jesse Howarth and Michael Ivey authored and riot-builder committed Dec 2, 2014
    Configuration menu
    Copy the full SHA
    7e05320 View commit details
    Browse the repository at this point in the history

  2. Add (required) to help of flags that are required.

    @riot-builder
    Jesse Howarth and Michael Ivey authored and riot-builder committed Dec 2, 2014
    Configuration menu
    Copy the full SHA
    73e64a1 View commit details
    Browse the repository at this point in the history

  3. Add tests for required flags

    @riot-builder
    Jesse Howarth and Michael Ivey authored and riot-builder committed Dec 2, 2014
    Configuration menu
    Copy the full SHA
    4b2fcdb View commit details
    Browse the repository at this point in the history

  4. Merge pull request #1 from ivey/required_flags 

    Required flags
    @jhowarth
    jhowarth committed Dec 2, 2014
    Configuration menu
    Copy the full SHA
    8f1fb06 View commit details
    Browse the repository at this point in the history

Commits on Mar 2, 2015

  1. Remove debugging

    jhowarth committed Mar 2, 2015
    Configuration menu
    Copy the full SHA
    cbd9529 View commit details
    Browse the repository at this point in the history

  2. DRY error handling

    jhowarth committed Mar 2, 2015
    Configuration menu
    Copy the full SHA
    e67e05f View commit details
    Browse the repository at this point in the history

  3. dry error messages

    jhowarth committed Mar 2, 2015
    Configuration menu
    Copy the full SHA
    6023f37 View commit details
    Browse the repository at this point in the history

  4. don't require flags when the help flag is included

    jhowarth committed Mar 2, 2015
    Configuration menu
    Copy the full SHA
    145da32 View commit details
    Browse the repository at this point in the history

  5. Merge pull request #2 from ivey/requiredFlags 

    Required flags
    @jhowarth
    jhowarth committed Mar 2, 2015
    Configuration menu
    Copy the full SHA
    b5844af View commit details
    Browse the repository at this point in the history

  6. Merge remote-tracking branch 'upstream/master' 

    Conflicts:
	app.go
	command.go
	flag.go
    jhowarth committed Mar 2, 2015
    Configuration menu
    Copy the full SHA
    a6482d2 View commit details
    Browse the repository at this point in the history

Commits on Mar 3, 2015

  1. Copy the writer of the App to the subcommand App

    jhowarth committed Mar 3, 2015
    Configuration menu
    Copy the full SHA
    aba73ce View commit details
    Browse the repository at this point in the history

Commits on Jul 12, 2019

  1. Merge branch 'master' into required_flags

    Lynn Cyrin committed Jul 12, 2019
    Configuration menu
    Copy the full SHA
    138dbaa View commit details
    Browse the repository at this point in the history

  2. reduce diff???

    Lynn Cyrin committed Jul 12, 2019
    Configuration menu
    Copy the full SHA
    ce16301 View commit details
    Browse the repository at this point in the history

  3. reduce diff

    Lynn Cyrin committed Jul 12, 2019
    Configuration menu
    Copy the full SHA
    fa8187f View commit details
    Browse the repository at this point in the history

  4. merge in test file

    Lynn Cyrin committed Jul 12, 2019
    Configuration menu
    Copy the full SHA
    e6842c0 View commit details
    Browse the repository at this point in the history

  5. reduce diff

    Lynn Cyrin committed Jul 12, 2019
    Configuration menu
    Copy the full SHA
    f7d5e2c View commit details
    Browse the repository at this point in the history

  6. update Run command

    Lynn Cyrin committed Jul 12, 2019
    Configuration menu
    Copy the full SHA
    30a71dc View commit details
    Browse the repository at this point in the history

  7. reduce diff

    Lynn Cyrin committed Jul 12, 2019
    Configuration menu
    Copy the full SHA
    9c299e7 View commit details
    Browse the repository at this point in the history

  8. reduce diff

    Lynn Cyrin committed Jul 12, 2019
    Configuration menu
    Copy the full SHA
    0608059 View commit details
    Browse the repository at this point in the history

  9. reduce diff

    Lynn Cyrin committed Jul 12, 2019
    Configuration menu
    Copy the full SHA
    3d2d697 View commit details
    Browse the repository at this point in the history

  10. update func name

    Lynn Cyrin committed Jul 12, 2019
    Configuration menu
    Copy the full SHA
    af627c7 View commit details
    Browse the repository at this point in the history

  11. add required attr to generator

    Lynn Cyrin committed Jul 12, 2019
    Configuration menu
    Copy the full SHA
    310bfeb View commit details
    Browse the repository at this point in the history

  12. add IsRequired to generator

    Lynn Cyrin committed Jul 12, 2019
    Configuration menu
    Copy the full SHA
    62e99ad View commit details
    Browse the repository at this point in the history

  13. remove manual isRequired funcs

    Lynn Cyrin committed Jul 12, 2019
    Configuration menu
    Copy the full SHA
    8a58b7e View commit details
    Browse the repository at this point in the history

  14. ./generate-flag-types cli -i flag-types.json -o flag_generated.go

    Lynn Cyrin committed Jul 12, 2019
    Configuration menu
    Copy the full SHA
    922d231 View commit details
    Browse the repository at this point in the history

  15. backwards compatible RequiredFlag implementation

    Lynn Cyrin committed Jul 12, 2019
    Configuration menu
    Copy the full SHA
    6a2ae78 View commit details
    Browse the repository at this point in the history

Commits on Jul 13, 2019

  1. quote the flag name

    Lynn Cyrin committed Jul 13, 2019
    Configuration menu
    Copy the full SHA
    f6777bf View commit details
    Browse the repository at this point in the history

  2. update tests

    Lynn Cyrin committed Jul 13, 2019
    Configuration menu
    Copy the full SHA
    550ed20 View commit details
    Browse the repository at this point in the history

  3. add update integration with the help output

    Lynn Cyrin committed Jul 13, 2019
    Configuration menu
    Copy the full SHA
    746866c View commit details
    Browse the repository at this point in the history

  4. fill out test cases

    Lynn Cyrin committed Jul 13, 2019
    Configuration menu
    Copy the full SHA
    80d7e91 View commit details
    Browse the repository at this point in the history

  5. update tests

    Lynn Cyrin committed Jul 13, 2019
    Configuration menu
    Copy the full SHA
    cf82480 View commit details
    Browse the repository at this point in the history

  6. tabs

    Lynn Cyrin committed Jul 13, 2019
    Configuration menu
    Copy the full SHA
    17108e1 View commit details
    Browse the repository at this point in the history

  7. docs

    Lynn Cyrin committed Jul 13, 2019
    Configuration menu
    Copy the full SHA
    f00f35c View commit details
    Browse the repository at this point in the history

Commits on Jul 15, 2019

  1. visually shorten logic

    Lynn Cyrin committed Jul 15, 2019
    Configuration menu
    Copy the full SHA
    9293f5b View commit details
    Browse the repository at this point in the history

Commits on Jul 17, 2019

  1. add handling for multiple required flags

    Lynn Cyrin committed Jul 17, 2019
    Configuration menu
    Copy the full SHA
    cdc7af7 View commit details
    Browse the repository at this point in the history

  2. use strings.Join

    Lynn Cyrin committed Jul 17, 2019
    Configuration menu
    Copy the full SHA
    01d5cfa View commit details
    Browse the repository at this point in the history

  3. copy update

    @coilysiren
    coilysiren committed Jul 17, 2019
    Configuration menu
    Copy the full SHA
    32d84d8 View commit details
    Browse the repository at this point in the history

Commits on Jul 18, 2019

  1. wording shift

    Lynn Cyrin committed Jul 18, 2019
    Configuration menu
    Copy the full SHA
    cc1cf8c View commit details
    Browse the repository at this point in the history

  2. add subcommand

    Lynn Cyrin committed Jul 18, 2019
    Configuration menu
    Copy the full SHA
    3002886 View commit details
    Browse the repository at this point in the history

  3. cleanup subcommand and specs

    Lynn Cyrin committed Jul 18, 2019
    Configuration menu
    Copy the full SHA
    2299852 View commit details
    Browse the repository at this point in the history

  4. show errors

    Lynn Cyrin committed Jul 18, 2019
    Configuration menu
    Copy the full SHA
    19140e1 View commit details
    Browse the repository at this point in the history

  5. reduce diff

    Lynn Cyrin committed Jul 18, 2019
    Configuration menu
    Copy the full SHA
    d8985dc View commit details
    Browse the repository at this point in the history

  6. remove unused code

    Lynn Cyrin committed Jul 18, 2019
    Configuration menu
    Copy the full SHA
    7ce0af1 View commit details
    Browse the repository at this point in the history

Commits on Jul 29, 2019

  1. cleanup tests, check required flags in more places

    Lynn Cyrin committed Jul 29, 2019
    Configuration menu
    Copy the full SHA
    23f09ac View commit details
    Browse the repository at this point in the history

  2. reset generated flags changes

    Lynn Cyrin committed Jul 29, 2019
    Configuration menu
    Copy the full SHA
    9ec594d View commit details
    Browse the repository at this point in the history

  3. Revert "reset generated flags changes" 

    This reverts commit 9ec594d.
    Lynn Cyrin committed Jul 29, 2019
    Configuration menu
    Copy the full SHA
    386b379 View commit details
    Browse the repository at this point in the history

Commits on Aug 2, 2019

  1. remove showFlagError, we can use the help printer assertion to accomp… 

    …lish the same goal
    Lynn Cyrin committed Aug 2, 2019
    Configuration menu
    Copy the full SHA
    9438aba View commit details
    Browse the repository at this point in the history

  2. remove unused thing

    Lynn Cyrin committed Aug 2, 2019
    Configuration menu
    Copy the full SHA
    714a73f View commit details
    Browse the repository at this point in the history

  3. update test to reflect app flag usage

    Lynn Cyrin committed Aug 2, 2019
    Configuration menu
    Copy the full SHA
    95d3a86 View commit details
    Browse the repository at this point in the history

  4. update test names

    Lynn Cyrin committed Aug 2, 2019
    Configuration menu
    Copy the full SHA
    7b9e16b View commit details
    Browse the repository at this point in the history

  5. add test cases

    Lynn Cyrin committed Aug 2, 2019
    Configuration menu
    Copy the full SHA
    3d6eec8 View commit details
    Browse the repository at this point in the history

  6. expand test cases

    Lynn Cyrin committed Aug 2, 2019
    Configuration menu
    Copy the full SHA
    595382c View commit details
    Browse the repository at this point in the history

  7. more test cases

    Lynn Cyrin committed Aug 2, 2019
    Configuration menu
    Copy the full SHA
    d4740d1 View commit details
    Browse the repository at this point in the history

  8. add typed error assertions

    Lynn Cyrin committed Aug 2, 2019
    Configuration menu
    Copy the full SHA
    78db152 View commit details
    Browse the repository at this point in the history

  9. more test cases

    Lynn Cyrin committed Aug 2, 2019
    Configuration menu
    Copy the full SHA
    45f2b3d View commit details
    Browse the repository at this point in the history

  10. rename cases

    Lynn Cyrin committed Aug 2, 2019
    Configuration menu
    Copy the full SHA
    ef9acb4 View commit details
    Browse the repository at this point in the history

  11. update comments

    Lynn Cyrin committed Aug 2, 2019
    Configuration menu
    Copy the full SHA
    fdd4d10 View commit details
    Browse the repository at this point in the history

  12. cleanup some issues with error display

    Lynn Cyrin committed Aug 2, 2019
    Configuration menu
    Copy the full SHA
    f21b22d View commit details
    Browse the repository at this point in the history

  13. add environment variable support 🎉

    Lynn Cyrin committed Aug 2, 2019
    Configuration menu
    Copy the full SHA
    38f9e16 View commit details
    Browse the repository at this point in the history

  14. Update command.go

    @coilysiren
    coilysiren committed Aug 2, 2019
    Configuration menu
    Copy the full SHA
    f4128a0 View commit details
    Browse the repository at this point in the history

  15. add env var tests

    Lynn Cyrin committed Aug 2, 2019
    Configuration menu
    Copy the full SHA
    d7ec4e8 View commit details
    Browse the repository at this point in the history

  16. remove help assertion stuff

    Lynn Cyrin committed Aug 2, 2019
    Configuration menu
    Copy the full SHA
    60fb297 View commit details
    Browse the repository at this point in the history

  17. Merge branch 'master' into required-flags-take-2

    @asahasrabuddhe
    asahasrabuddhe committed Aug 2, 2019
    Configuration menu
    Copy the full SHA
    f8ba505 View commit details
    Browse the repository at this point in the history